Symtable

[albertjan]

@s-cork all the visit stuff is done now analyse remains

[albertjan]

left a few comments for you

[albertjan]

addressed most of the comments 😄 few outstanding q's.

Lets think about how we can put this through it's paces

[github-actions[bot]]

test result: ok. 559 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (23476ms)

[github-actions[bot]]

test result: ok. 559 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (31930ms)

[albertjan]

it appears we broke the ast tests at some point haha we didn't actually exit with an error code 😄

[s-cork]

oh no so blissfully unaware

[s-cork]

the dump function errors are escape characters for strings so we can just make that a separate pr fix

[albertjan]

Alright it generates a SymbolTable for all of the run-tests, now the small matter of proving that is the correct symbol table 😬

[albertjan]

Another good point if you're talking to Anvil about typescript. I wrote all of this without running it once. And I only had to change a few little things.

[albertjan]

Why not do a call inside SEQ instead? bind is expensive

    SEQ<T>(visitor: (node: T) => void, nodes: (T | null)[]) {
        assert(Array.isArray(nodes), "SEQ: nodes isn't array? got " + nodes.toString());
        for (const node of nodes) {
            if (node) {
                visitor.call(this, node);
            }
        }
    }

thanks!

[albertjan]

ls -1 run-tests/*.py | xargs -n1 vr symtable if you want to see it in action

[s-cork]

script hasn't been pushed yet...

[albertjan]

@s-cork tests pass 😄

[s-cork]

lgtm - merge this and then create new prs for whatever comes next?

[albertjan]

Yeah sounds good to me.