chore: update kc healthcheck command to test status code

[nmathew98]

https://www.gnu.org/software/wget/manual/html_node/Exit-Status.html

[github-actions[bot]]

Title

chore: update kc healthcheck command to test status code

---

User description

https://www.gnu.org/software/wget/manual/html_node/Exit-Status.html

---

PR Type

enhancement

---

Description

• Enhanced the healthcheck command in the Docker Compose file to handle wget exit status code 8, which indicates a server error.
• The command now checks if the exit status is 8 and does not exit with an error in that case, improving the robustness of the healthcheck.

---

Changes walkthrough 📝

	Relevant files
Enhancement	docker-compose.yml Update healthcheck command to handle wget exit status code rollout/docker-compose.yml Updated healthcheck command to handle specific wget exit status. Modified the healthcheck test to include a condition for exit status code 8. +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions[bot]]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🏅 Score: 85

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Bug The new healthcheck command includes a condition that checks for a specific exit code (8) from wget. This may lead to confusion if the command fails for reasons other than the expected exit code. It should be verified that this behavior is intended and documented.

[github-actions[bot]]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Maintainability	Improve the healthcheck command by clarifying the exit code handling ___ **Consider using a more specific exit code check instead of relying on the general exit status to improve clarity and maintainability.** [rollout/docker-compose.yml [83]](https://github.com/skulpturenz/shared-resources/pull/274/files#diff-be092be3b541d71eab5969ed2268083690f8982a3f84e80e1ba3035ead16882fR83-R83) ```diff -test: [ "CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost:8080 || test $? -eq 8 || exit 1" ] +test: [ "CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost:8080 || exit 8" ] ``` Suggestion importance[1-10]: 5 Why: The suggestion to use a more specific exit code check can enhance clarity and maintainability of the healthcheck command, but the proposed change may not significantly impact functionality since the original command already handles exit codes.	5

[github-actions[bot]]

:tropical_drink: preview on network/skulpture/shared-infrastructure

Pulumi report

Previewing update (shared-infrastructure)

View Live: https://app.pulumi.com/skulpture/network/shared-infrastructure/previews/86a7481c-4e09-4281-a561-964fb26f22b0

@ Previewing update......
Downloading plugin gcp-7.38.0: starting
Downloading plugin digitalocean-4.34.0: starting
Downloading plugin digitalocean-4.34.0: done
Installing plugin digitalocean-4.34.0: starting
Downloading plugin gcp-7.38.0: done
Installing plugin gcp-7.38.0: starting
Installing plugin digitalocean-4.34.0: done
@ Previewing update....
Installing plugin gcp-7.38.0: done

@ Previewing update..........................................................................
pulumi:pulumi:Stack network-shared-infrastructure running 
@ Previewing update....
pulumi:pulumi:Stack network-shared-infrastructure  
Resources:
12 unchanged

[github-actions[bot]]

:tropical_drink: preview on authnz/skulpture/shared-authnz

Pulumi report

Previewing update (shared-authnz)

View Live: https://app.pulumi.com/skulpture/authnz/shared-authnz/previews/4ed149d4-0a9d-40b0-95cb-049d2c2a2875

@ Previewing update........
Downloading plugin cloudflare-5.42.0: starting
Downloading plugin gcp-7.38.0: starting
Downloading plugin cloudflare-5.42.0: done
Downloading plugin gcp-7.38.0: done
Installing plugin cloudflare-5.42.0: starting
Installing plugin gcp-7.38.0: starting
@ Previewing update....
Installing plugin cloudflare-5.42.0: done
Installing plugin gcp-7.38.0: done

@ Previewing update...........................................................................
pulumi:pulumi:Stack authnz-shared-authnz running 
@ Previewing update....
pulumi:pulumi:Stack authnz-shared-authnz  
Resources:
4 unchanged

[github-actions[bot]]

:tropical_drink: preview on rollout/skulpture/shared-rollout

Pulumi report

Previewing update (shared-rollout)

View Live: https://app.pulumi.com/skulpture/rollout/shared-rollout/previews/e52468f2-9eaf-46df-9eca-bc1a11b64973

@ Previewing update......
Downloading plugin gcp-7.38.0: starting
Downloading plugin cloudflare-5.42.0: starting
Downloading plugin cloudflare-5.42.0: done
Downloading plugin gcp-7.38.0: done
Installing plugin cloudflare-5.42.0: starting
Installing plugin gcp-7.38.0: starting
@ Previewing update....
Installing plugin cloudflare-5.42.0: done
@ Previewing update....
Installing plugin gcp-7.38.0: done

@ Previewing update...............................................................................
pulumi:pulumi:Stack rollout-shared-rollout running 
@ Previewing update....
pulumi:pulumi:Stack rollout-shared-rollout  
Resources:
4 unchanged

[github-actions[bot]]

:tropical_drink: preview on telemetry/skulpture/shared-telemetry

Pulumi report

Previewing update (shared-telemetry)

View Live: https://app.pulumi.com/skulpture/telemetry/shared-telemetry/previews/560d64c8-a3d1-4c24-a1c7-c5f7663e1de9

@ Previewing update.......
Downloading plugin cloudflare-5.42.0: starting
Downloading plugin cloudflare-5.42.0: done
Installing plugin cloudflare-5.42.0: starting
Downloading plugin gcp-7.38.0: starting
@ Previewing update....
Installing plugin cloudflare-5.42.0: done
Downloading plugin gcp-7.38.0: done
Installing plugin gcp-7.38.0: starting
@ Previewing update....
Installing plugin gcp-7.38.0: done

@ Previewing update.............................................................................
pulumi:pulumi:Stack telemetry-shared-telemetry running 
@ Previewing update....
pulumi:pulumi:Stack telemetry-shared-telemetry  
Resources:
4 unchanged