Update for 2020 - Githubissues

themikesmith commented 4 years ago

Pending final validation from library staff

themikesmith commented 4 years ago

Hi there, I'm writing my own dissertation now, and have updated your template for 2020 guidelines. I've begun uploads on CTAN and Overleaf too.

skulumani commented 4 years ago

Thanks @themikesmith much appreciated. I'll review it soon.

Can you upload the packages to CTAN/Overleaf? I thought it had some kind of permission system or can anyone just update the package?

themikesmith commented 4 years ago

Thanks very much!

FYI:

I resolved some formatting issues, played around with package requirements and import order, among other things, and defined some new variables for ease of user manipulation in tex/frontmatter.tex based on what I found myself needing to edit.
Hopefully I did everything right as it's been a bit since I've worked in LaTeX; the only warnings remaining are "underfull/overfull hbox" related to the content in tex/manual.tex, judging by my Overleaf project: https://www.overleaf.com/read/skfcphfsfssr

Can you upload the packages to CTAN/Overleaf? I thought it had some kind of permission system or can anyone just update the package?

I have no idea whether either of the CTAN or Overleaf uploads will succeed, but I've submitted to be reviewed for both. I think CTAN will (if it succeeds) handle versioning properly, but Overleaf is TBD - it might create a new template. I've asked Overleaf if templates require re-submission or do they automatically pick up changes in the referential template project --- do you happen to know the answer? Please feel free to re-upload these if you have any automatic hooks or scripts that link everything nicely together

skulumani commented 4 years ago

I think the best approach is to wait for final approval from the library on the changes, then commit a final version here, then make sure the CTAN and Overleaf version match.

Also I think it's good to have a single version of this package available for all sources. And to ensure they all match. I have some scripts for CTAN I'll have to review so that'll be easy

themikesmith commented 4 years ago

Sounds good regarding approval. FYI, from Overleaf: Thanks for getting in touch! You can update the same original project and click "Submit" > "Overleaf Gallery" again. This will update the template in the Gallery, after it's been approved.

On Wed, Feb 26, 2020 at 8:38 PM Shankar Kulumani notifications@github.com wrote:

I think the best approach is to wait for final approval from the library on the changes, then commit a final version here, then make sure the CTAN and Overleaf version match.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34?email_source=notifications&email_token=ABM2N7BFVFUOBDKM5FP7773RE4KQLA5CNFSM4K4PNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCSCAY#issuecomment-591732995, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM2N7GEMPJGVGWWHC75XR3RE4KQLANCNFSM4K4PNKLQ .

skulumani commented 4 years ago

Also I'm assuming you're already in contact with the ETD office at the library? And that they're reviewing your updated thesis template?

themikesmith commented 4 years ago

Correct, yep! Should hear soon. I'll have a few more tweaks to commit I imagine... Was it this nitpicky when you were writing yours?

On Thu, Feb 27, 2020, 6:37 AM Shankar Kulumani notifications@github.com wrote:

Also I'm assuming you're already in contact with the ETD office at the library? And that they're reviewing your updated thesis template?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34?email_source=notifications&email_token=ABM2N7FAXOJF7WHTK3KKG4LRE6QWZA5CNFSM4K4PNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENEBGWY#issuecomment-591926107, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM2N7CYYZRAROZYFL3FZQ3RE6QWZANCNFSM4K4PNKLQ .

skulumani commented 4 years ago

Was it this nitpicky when you were writing yours?

It took me over a year to get it finally approved. Not sure why they feel the need to change it. I'm assuming it's a new person at ETD who is just following their own prerogative.

themikesmith commented 4 years ago

Hi there, I received what I believe should be the last feedback from the gw library. I have one question for you: I had to use the tocloft package to indent the table of contents, but this disregarded (I think) some of the formatting you had done in the class file. This starts on current line 906. What's the best way to know what was overridden and what wasn't? We can comment or remove what is unnecessary to avoid future confusion Best, Mike

On Thu, Feb 27, 2020, 10:16 PM Shankar Kulumani notifications@github.com wrote:

Was it this nitpicky when you were writing yours?

It took me over a year to get it finally approved. Not sure why they feel the need to change it. I'm assuming it's a new person at ETD who is just following their own prerogative.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34?email_source=notifications&email_token=ABM2N7EUVEGAFDX4NLXYM2TRFB6YVA5CNFSM4K4PNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENG2KLI#issuecomment-592291117, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM2N7AWTFKVBFJYSLACQRTRFB6YVANCNFSM4K4PNKLQ .

skulumani commented 4 years ago

Thanks! @themikesmith

I have one question for you: I had to use the tocloft package to indent the table of contents, but this disregarded (I think) some of the formatting you had done in the class file.

I'm sure this is fine and probably a better way to do it than what I originally did in the class file. I'll have to review it to remember how I had it setup. I'll try to look at your changes this weekend.

Hi there, I received what I believe should be the last feedback from the gw library.

Can you add a screenshot/PDF of whatever "approved" message you have from the library? That was we can include it when someone new shows up and tries to change things.

Could you also ask why this is being changed in the first place from 2018? The reason for a standard/template is consistency.

themikesmith commented 4 years ago

No problem! Another question: do you wish to continue maintaining this? I can take over if you want, but I can't promise all the fancy services like Travis and others at the top of your Readme. Rest of replies inline Best Michael

On Wed, Mar 4, 2020, 1:18 PM Shankar Kulumani notifications@github.com wrote:

Thanks! @themikesmith https://github.com/themikesmith

I have one question for you: I had to use the tocloft package to indent the table of contents, but this disregarded (I think) some of the formatting you had done in the class file.

I'm sure this is fine and probably a better way to do it than what I originally did in the class file. I'll have to review it to remember how I had it setup. I'll try to look at your changes this weekend.

Please do. I felt very hacky!

Hi there, I received what I believe should be the last feedback from the gw library.

Can you add a screenshot/PDF of whatever "approved" message you have from the library? That was we can include it when someone new shows up and tries to change things.

Perhaps, yes, but it's an email chain. I'm not sure how I can finagle Gmail to display what I want. I can try soon

Could you also ask why this is being changed in the first place from 2018? The reason for a standard/template is consistency.

That, I unfortunately don't know; likely above my pay grade. It looks like it changed in 2019 across the university. Maybe this change is the beginning of consistency?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34?email_source=notifications&email_token=ABM2N7F74BCAAOLUDBC6JKDRF2LPJA5CNFSM4K4PNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENZMEBQ#issuecomment-594723334, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM2N7E257WO737Q3DJD3O3RF2LPJANCNFSM4K4PNKLQ .

skulumani commented 4 years ago

I'm getting the following errors:

thesis-sample.tex|277 warning| Underfull \hbox (badness 2409) in paragraph at lines 277--279
thesis-sample.tex|280 warning| Underfull \hbox (badness 1616) in paragraph at lines 280--283
thesis-sample.tex|298 warning| Overfull \hbox (4.56004pt too wide) in paragraph at lines 298--306
thesis-sample.tex|289 warning| Overfull \hbox (17.48888pt too wide) in paragraph at lines 289--309
thesis-sample.tex|312 warning| LaTeX Warning: Citation `newton1999' on page 10 undefined on input line 312.
thesis-sample.tex|315 warning| LaTeX Warning: Citation `kalman1960' on page 10 undefined on input line 315.
thesis-sample.tex|315 warning| LaTeX Warning: Citation `shannon1949' on page 10 undefined on input line 315.
./thesis-sample.bbl|1 error| Use of \reserved@a doesn't match its definition.
./thesis-sample.bbl|1 error| Argument of \ttl@assign@i has an extra }.
./thesis-sample.bbl|1 error| Paragraph ended before \ttl@assign@i was complete.
./thesis-sample.bbl|1 error| Argument of \ttl@assign@i has an extra }.
./thesis-sample.bbl|1 error| Paragraph ended before \ttl@assign@i was complete.
./thesis-sample.bbl|1 error| Extra }, or forgotten \endgroup.
thesis-sample.tex|| LaTeX Warning: There were undefined references.
thesis-sample.tex|| LaTeX Warning: Label(s) may have changed. Rerun to get cross-references right.

Can you figure out what's going on?

themikesmith commented 4 years ago

Hi Shankar, unfortunately I'm getting no errors. In addition, I am only getting three warnings at this point (I resolved a couple of the others you mentioned) -- but all of the warnings are from the manual chapter that was created before my contributions to the repo. See below. Could you try clearing your cache and intermediate build files and recompiling? Alternatively, did a code merge fail on your end? See attached for a zip of the project, too, in case that helps you reset. Best, Mike [image: image.png]

On Sat, Mar 7, 2020 at 3:06 PM Shankar Kulumani notifications@github.com wrote:

I'm getting the following errors:

thesis-sample.tex|277 warning| Underfull \hbox (badness 2409) in paragraph at lines 277--279 thesis-sample.tex|280 warning| Underfull \hbox (badness 1616) in paragraph at lines 280--283 thesis-sample.tex|298 warning| Overfull \hbox (4.56004pt too wide) in paragraph at lines 298--306 thesis-sample.tex|289 warning| Overfull \hbox (17.48888pt too wide) in paragraph at lines 289--309 thesis-sample.tex|312 warning| LaTeX Warning: Citation newton1999' on page 10 undefined on input line 312. thesis-sample.tex|315 warning| LaTeX Warning: Citationkalman1960' on page 10 undefined on input line 315. thesis-sample.tex|315 warning| LaTeX Warning: Citation `shannon1949' on page 10 undefined on input line 315. ./thesis-sample.bbl|1 error| Use of \reserved@a doesn't match its definition. ./thesis-sample.bbl|1 error| Argument of \ttl@assign@i has an extra }. ./thesis-sample.bbl|1 error| Paragraph ended before \ttl@assign@i was complete. ./thesis-sample.bbl|1 error| Argument of \ttl@assign@i has an extra }. ./thesis-sample.bbl|1 error| Paragraph ended before \ttl@assign@i was complete. ./thesis-sample.bbl|1 error| Extra }, or forgotten \endgroup. thesis-sample.tex|| LaTeX Warning: There were undefined references. thesis-sample.tex|| LaTeX Warning: Label(s) may have changed. Rerun to get cross-references right.

Can you figure out what's going on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34?email_source=notifications&email_token=ABM2N7D2LDRDGRMEOUQTW73RGKSLVA5CNFSM4K4PNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOEEHTA#issuecomment-596132812, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM2N7HLNIHEGDZ27AOZYFDRGKSLVANCNFSM4K4PNKLQ .

skulumani commented 4 years ago

No worries. Let me check on it

On Sat, Mar 7, 2020, 17:52 Michael Smith notifications@github.com wrote:

Hi Shankar, unfortunately I'm getting no errors. In addition, I am only getting three warnings at this point (I resolved a couple of the others you mentioned) -- but all of the warnings are from the manual chapter that was created before my contributions to the repo. See below. Could you try clearing your cache and intermediate build files and recompiling? Alternatively, did a code merge fail on your end? See attached for a zip of the project, too, in case that helps you reset. Best, Mike [image: image.png]

On Sat, Mar 7, 2020 at 3:06 PM Shankar Kulumani notifications@github.com wrote:

I'm getting the following errors:

thesis-sample.tex|277 warning| Underfull \hbox (badness 2409) in paragraph at lines 277--279 thesis-sample.tex|280 warning| Underfull \hbox (badness 1616) in paragraph at lines 280--283 thesis-sample.tex|298 warning| Overfull \hbox (4.56004pt too wide) in paragraph at lines 298--306 thesis-sample.tex|289 warning| Overfull \hbox (17.48888pt too wide) in paragraph at lines 289--309 thesis-sample.tex|312 warning| LaTeX Warning: Citation newton1999' on page 10 undefined on input line 312. thesis-sample.tex|315 warning| LaTeX Warning: Citationkalman1960' on page 10 undefined on input line 315. thesis-sample.tex|315 warning| LaTeX Warning: Citation `shannon1949' on page 10 undefined on input line 315. ./thesis-sample.bbl|1 error| Use of \reserved@a doesn't match its definition. ./thesis-sample.bbl|1 error| Argument of \ttl@assign@i has an extra }. ./thesis-sample.bbl|1 error| Paragraph ended before \ttl@assign@i was complete. ./thesis-sample.bbl|1 error| Argument of \ttl@assign@i has an extra }. ./thesis-sample.bbl|1 error| Paragraph ended before \ttl@assign@i was complete. ./thesis-sample.bbl|1 error| Extra }, or forgotten \endgroup. thesis-sample.tex|| LaTeX Warning: There were undefined references. thesis-sample.tex|| LaTeX Warning: Label(s) may have changed. Rerun to get cross-references right.

Can you figure out what's going on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/skulumani/thesis-gwu/pull/34?email_source=notifications&email_token=ABM2N7D2LDRDGRMEOUQTW73RGKSLVA5CNFSM4K4PNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOEEHTA#issuecomment-596132812 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABM2N7HLNIHEGDZ27AOZYFDRGKSLVANCNFSM4K4PNKLQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34?email_source=notifications&email_token=ABIFUZXH3ELE7TCDMY4FGHDRGLF3LA5CNFSM4K4PNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOEHLAQ#issuecomment-596145538, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIFUZUICZ6WGMRTIOTCOX3RGLF3LANCNFSM4K4PNKLQ .

skulumani commented 4 years ago

Another question: do you wish to continue maintaining this? I can take over if you want, but I can't promise all the fancy services like Travis and others at the top of your Readme. Rest of replies inline

I can add you as a contributor to this repo? That way all the other stuff should just keep working? And then the repo can still be used as the source for the template?

I'll try to double check the thesis tonight. It might be a latex issue on my end. I tried installing texlive from the ubuntu repo instead of directly from texlive itself.

themikesmith commented 4 years ago

On Mon, Mar 9, 2020 at 8:45 AM Shankar Kulumani notifications@github.com wrote:

Another question: do you wish to continue maintaining this? I can take over if you want, but I can't promise all the fancy services like Travis and others at the top of your Readme. Rest of replies inline

I can add you as a contributor to this repo? That way all the other stuff should just keep working? And then the repo can still be used as the source for the template?

Sure if you like! Thanks

I'll try to double check the thesis tonight. It might be a latex issue on my end. I tried installing texlive from the ubuntu repo instead of directly from texlive itself.

Sounds good. Let me know if I can assist.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34?email_source=notifications&email_token=ABM2N7ALX6LRAKWZM3AMYXDRGTXHLA5CNFSM4K4PNKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOG6YXQ#issuecomment-596503646, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM2N7BMAGXEDHWKYMLXKALRGTXHLANCNFSM4K4PNKLQ .

skulumani commented 4 years ago

Thanks for the help. Just merged and pushed to CTAN.

Hope it's good!

themikesmith commented 4 years ago

HI Shankar, sounds good! How did you resolve the issues? Merged and pushed to CTAN - excellent! What's outstanding:

Overleaf? I will handle this by updating the template
Are you still open to me contributing officially to the repo?
Do you want me to update the README indicating 2020 compatibility?

Best Mike

On Fri, Mar 13, 2020 at 9:43 AM Shankar Kulumani notifications@github.com wrote:

Thanks for the help. Just merged and pushed to CTAN.

Hope it's good!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34#issuecomment-598726579, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM2N7GBMQ57V6LUQKXJJ73RHI2A5ANCNFSM4K4PNKLQ .

themikesmith commented 4 years ago

I didn't see access to your repo, so I've just updated the README in mine and made another pull request.

Looking forward to hearing from you on the admin status and rest of the README

Stay healthy, Mike

On Fri, Mar 13, 2020 at 10:56 AM Mike Smith themikesmith@gmail.com wrote:

HI Shankar, sounds good! How did you resolve the issues? Merged and pushed to CTAN - excellent! What's outstanding:

Overleaf? I will handle this by updating the template

Are you still open to me contributing officially to the repo?

Do you want me to update the README indicating 2020 compatibility?

Best Mike

On Fri, Mar 13, 2020 at 9:43 AM Shankar Kulumani notifications@github.com wrote:

Thanks for the help. Just merged and pushed to CTAN.

Hope it's good!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34#issuecomment-598726579, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM2N7GBMQ57V6LUQKXJJ73RHI2A5ANCNFSM4K4PNKLQ .

skulumani commented 4 years ago

Sorry! I just invited you as a collaborator. Let me know if it works

On Fri, Mar 13, 2020 at 5:33 PM Michael Smith notifications@github.com wrote:

I didn't see access to your repo, so I've just updated the README in mine and made another pull request.

Looking forward to hearing from you on the admin status and rest of the README

Stay healthy, Mike

On Fri, Mar 13, 2020 at 10:56 AM Mike Smith themikesmith@gmail.com wrote:

HI Shankar, sounds good! How did you resolve the issues? Merged and pushed to CTAN - excellent! What's outstanding:

Overleaf? I will handle this by updating the template

Are you still open to me contributing officially to the repo?

Do you want me to update the README indicating 2020 compatibility?

Best Mike

On Fri, Mar 13, 2020 at 9:43 AM Shankar Kulumani < notifications@github.com> wrote:

Thanks for the help. Just merged and pushed to CTAN.

Hope it's good!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/skulumani/thesis-gwu/pull/34#issuecomment-598726579 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABM2N7GBMQ57V6LUQKXJJ73RHI2A5ANCNFSM4K4PNKLQ

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/skulumani/thesis-gwu/pull/34#issuecomment-598920952, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIFUZQUGJ4NMFNXM6I6WN3RHKRBNANCNFSM4K4PNKLQ .

skulumani / thesis-gwu

Update for 2020 #34