skunkforce / OmnAIView

This Repository contains the OmnAIView Software, which is used in the AW4null Research Projects
https://www.autowerkstatt40.org/
MIT License
3 stars 4 forks source link

loading old data and a few code refinements #156

Closed R-Abbasi closed 6 months ago

R-Abbasi commented 6 months ago

PS: This is the first step to the related issue as it's not yet completely clear how the implementation and design are going to be for the feature.

AKMaily commented 6 months ago

Pressing the reset button in the software should not reset the loaded data.

R-Abbasi commented 6 months ago

Pressing the reset button in the software should not reset the loaded data.

It wasn't mentioned in the task description. Could you explain that a little more, please?

R-Abbasi commented 6 months ago

Loading the data works fine, although it should not be deleted when the user resets the measurement. There should be an extra reset button in the "Found Devices" section where the user can reset all loaded data.

Resetting files loaded data is done using the checkbox. A file's data is loaded and displayed as soon as the checkbox is checked and erased/reset otherwise.

AKMaily commented 6 months ago

Loading the data works fine, although it should not be deleted when the user resets the measurement. There should be an extra reset button in the "Found Devices" section where the user can reset all loaded data.

Resetting files loaded data is done using the checkbox. A file's data is loaded and displayed as soon as the checkbox is checked and erased/reset otherwise.

Yes the files are reset using the checkboxes which is correct. But they are also reset when the user has the following userflow: load old data--> measure new data with a scope (press play button)-->press reset button. In this case not only the measured data is reset but also all loaded files are reset which should not happen.

R-Abbasi commented 6 months ago

Managed something to still have the data shown even after pressing the reset button which is rather suitable for the first step.

AKMaily commented 6 months ago

Managed something to still have the data shown even after pressing the reset button which is rather suitable for the first step.

If you are finished with this version please commit it so we can test and review it

R-Abbasi commented 6 months ago

It's already implemented in the current commit.

AKMaily commented 6 months ago

It's already implemented in the current commit.

Okay great, i tested that. Not reseting the data with the Reset button now works, but if you try the following user flow: loading old data, not checking the box, search for devices --> start measurement --> reset measurement. The loaded data is displayed in the window even when it is not selected : image

Also now the user has no possibility to reset/ delete old data from the software. This should be possible with a delete button in the found devices region.

R-Abbasi commented 6 months ago

Fixed the bug.

AKMaily commented 6 months ago

Fixed the bug.

That is great, please also add the reset button for the found devices region so old loaded measurements can be reset