Font and style

[AKMaily]

Added a new Font and changed the corresponding submodule ImGuiInstance to the version where a different font is possible.

Changed the fixed fontsize in the config to match the new Font when the application starts the first time.

Added a different AI Logo for the OmnAIScope and changed its size.

Changed the colors in the application to match the logo and the overall design more.

The expected output looks like this:

The initial fontsize will be to large when the application first starts because it currently downloads the config from the master branch. This will be fixed when this PR is merged with the master.

[AKMaily]

Yes i did. Did you build it yourself or did you use one from the CI build ?

[R-Abbasi]

Used the executable from CI.

[R-Abbasi]

You may also use inline constexpr unsigned char AutoInternLogo_png[].

[R-Abbasi]

The path "config/config.json"; should be correct since it looks for the folder where the executable exists.

[R-Abbasi]

Have you tested something like this, please?

if (io.Fonts->AddFontFromFileTTF("fonts/Inter_24pt-Medium.ttf", 24.0f) != nullptr) {
               font2 = io.Fonts->AddFontFromFileTTF("fonts/Inter_24pt-Medium.ttf", 24.0f);
        }

The fonts folder is put in the same directory as the config one apparently.

[AKMaily]

The path "config/config.json"; should be correct since it looks for the folder where the executable exists.

Yes it was i changed it back to the original version

[AKMaily]

Have you tested something like this, please?

if (io.Fonts->AddFontFromFileTTF("fonts/Inter_24pt-Medium.ttf", 24.0f) != nullptr) {
              font2 = io.Fonts->AddFontFromFileTTF("fonts/Inter_24pt-Medium.ttf", 24.0f);
       }

The fonts folder is put in the same directory as the config one apparently.

Yes i tested that, the problem is that the fonts are not downloaded when the .exe starts, so the font can not be found. I am currently working on including the fonts in a binary file and using AddFontFromMemoryTTF.

[R-Abbasi]

I've not used custom fonts before but if you download the font and put it in the related folder, just like the json files, and provide with AddFontFromFileTTF the absolute path to it, it may work.

[AKMaily]

Included it as a binary file. It should work now.

[R-Abbasi]

These're a few remaining notes at once:

• https://github.com/skunkforce/OmniView/pull/173#issuecomment-2316926444
• you can put your font array into a header pretty much the same way we used imagesHeader, and remove Inter_24pt-Medium.cpp :

  
  // fontHeader.hpp
  #ifndef FONT_HEADER_HPP
  #define FONT_HEADER_HPP

inline unsigned char Inter_24pt-Medium[] = { // ..

inline constexpr size_t Inter_24pt-Medium_len = sizeof(Inter_24pt-Medium) / sizeof(Inter_24pt-Medium[0]);

endif

- `CMakeLists` file needn't be changed, I suppose. 

As well as, `20.f` font pixels' size would suffice, I assume. 

[AKMaily]

Thank you for the review. I will change the datatype of the font data.

I tried using the method you suggested for the Font_Header before, the same way we use it for the images but it did not work.

The Error i get is :

(.text+0x0): multiple definition of `Inter_24pt_Medium_ttf'; CMakeFiles/OmniView.dir/src/main.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/bin/ld: CMakeFiles/OmniView.dir/src/style.cpp.o (symbol from plugin): in function `stbi_failure_reason':
(.text+0x0): multiple definition of `Inter_24pt_Medium_ttf_len'; CMakeFiles/OmniView.dir/src/main.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/bin/ld: CMakeFiles/OmniView.dir/src/style.cpp.o (symbol from plugin): in function `stbi_failure_reason':
(.text+0x0): multiple definition of `Inter_24pt_Medium_ttf'; CMakeFiles/OmniView.dir/src/main.cpp.o (symbol from plugin):(.text+0x0): first defined here

I defined the header with ifndef and define and included it.

[R-Abbasi]

Presumably you've not used inline. Also you need to include fontHeader.hpp only in the ImGuiInstance.hpp. And it should work.

[AKMaily]

Thank you! Done that, it works now.

[R-Abbasi]

Great! You forgot one little thing. Use inline constexpr unsigned int Inter_24pt-Medium_len = sizeof(Inter_24pt_Medium_ttf) / sizeof(Inter_24pt_Medium_ttf[0]); instead of inline unsigned int Inter_24pt_Medium_ttf_len = 342936; at the end of your header, please.

[AKMaily]

Could you explain why that is a better solution?

[R-Abbasi]

• constexpr: to explicitly tell the compiler to do things at compile-time rather than run-time
• If you use 342936 as the size and change it, E.g., drop a digit of that mistakenly (34293), the code will still work but a crash or unexpected result may happen. With sizeof(Inter_24pt_Medium_ttf) / sizeof(Inter_24pt_Medium_ttf[0]) that risk decreases because a change to it results in a compile-time error which can be caught and fixed much easier.

[AKMaily]

Done.

[R-Abbasi]

Here's my header:

// fontHeader.hpp
#ifndef FONT_HEADER_HPP
#define FONT_HEADER_HPP

inline unsigned char Inter_Medium[] = {
 // ...
 };

 inline constexpr unsigned Inter_Medium_len =
 sizeof(Inter_Medium) / sizeof(Inter_Medium[0]);
 #endif