skunkforce / OmniView

This Repository contains the OmniView Software, which is used in the AW4null Research Projects
https://www.autowerkstatt40.org/
MIT License
3 stars 4 forks source link

Enhancement: PlotRegion with background #104

Closed AKMaily closed 1 month ago

AKMaily commented 2 months ago

Right now the datawindow takes up all the space of the plot region. In the final version the datawindow should be in the middle of the plotregion. This is also shown in the picture below. The background color should be as in the picture. PlotRegion

R-Abbasi commented 1 month ago

Do you mean the wave in the figure below by the "datawindow", please? Capture2 The background color is also already white just like your figure.

AKMaily commented 1 month ago

I am referring to the data window, which is the area where the data, including the entire coordinate system (both the x and y axes as well as the waveform), is displayed. Currently, this data window occupies the entire space of the PlotRegion, resulting in no gap between the sidebarmenu, device list, and the data window. I envision a layout similar to the image I shared, where the data window is situated within the PlotRegion, which serves as the background. Moreover, I'd like the plot region to have a slightly different color than the data window for visual distinction.

R-Abbasi commented 1 month ago

How does this look like to you now, please?

Capture4

AKMaily commented 1 month ago

This looks good. Can you change the background color of the PlotRegion to a lighter tone?

R-Abbasi commented 1 month ago

https://github.com/skunkforce/OmniView/pull/117