skunkforce / OmniView

This Repository contains the OmniView Software, which is used in the AW4null Research Projects
https://www.autowerkstatt40.org/
MIT License
3 stars 4 forks source link

Enhancement: PlotStyle -> movable axes #134

Open DanielNowak98 opened 1 month ago

DanielNowak98 commented 1 month ago

It would be a valuable feature to have the ability to freely adjust the axes. In certain cases, this could empower workshop personnel to analyze various graph trends more effectively, aiding in their initial assessment of measurements.

Like seen on the ImPlot Page: https://github.com/epezent/implot?tab=readme-ov-file. This Feature is available in ImPlot.

Movable Axes

DanielNowak98 commented 1 month ago

Is this already possible? I only checked Funktionalities with one Scope. Have you tried it with more than one? @AKMaily @NP199?

AKMaily commented 4 weeks ago

This is not possible yet, but a good idea. Did you find a way where the user can change between one axis for all measurements and one where the axis are connected to the different data files ? In this case we should be able to implement it in the software.

NP199 commented 3 weeks ago

You would have to implement drag and drop items antd then the data handling must be refactored. It is possible for sure, but a bit of a challenge

NP199 commented 3 weeks ago

With the freely moving axis should be less of an challenge. I havn`t looked into it right now, but you can assign axes to an plot. So when each plot get its own axis, then the moving from each y-axis should be possible

AKMaily commented 3 weeks ago

In which way has the data handling to be refactored for this @NP199 ?

NP199 commented 3 weeks ago

When you want drag and drop items you need drag and drop items which are specified in Imgui. We must aplly to the data structure the framework needs to function.

The axis part could be just a new variable set of axis, but i don`t know the specific implementation either

AKMaily commented 3 weeks ago

Does this also has to happen if the user should be able to load old data into the Software itself? @NP199

NP199 commented 3 weeks ago

The user cant load old data into the software right now.

If you want to represent data, it depends not on how the data is loaded, but rather on the handling of the framework. So what does the framework allow me to do in terms of representing the data? Currently we are using a plot function that also accepts a standard data container which wouldn't be as simple with a drag and drop item. And this is regardless of where the data comes from (Input of the scope or user loading a file into the software).

But i am not sure if i understand the question right?

AKMaily commented 3 weeks ago

Okay i think i understand. A later feature should be: Loading old data into the Software and display it. Kinda the same way that Daniel suggested. I guess we should talk about handling the drag and drop items when we are implementing this feature.

DanielNowak98 commented 3 weeks ago

This feature is intended to provide an initial assessment of the data. By reading in old data and overlaying it using movable axes, the workshop employee can provide an initial evaluation of the generated data (e.g., good or bad).