search

skunkforce / OmniView

This Repository contains the OmniView Software, which is used in the AW4null Research Projects
https://www.autowerkstatt40.org/
MIT License
3 stars 4 forks source link

Local Building not possible for outside-collaborators without access to AI private Repos #36

Open R-Abbasi opened 10 months ago

R-Abbasi commented 10 months ago

In case of not having right access to the repo, the following errors turn up:

.../omniview$ git submodule update --init --recursive Submodule 'ImGuiInstance' (https://github.com/skunkforce/ImGuiInstance.git) registered for path 'ImGuiInstance' Submodule 'aglio' (https://github.com/dominicpoeschko/aglio.git) registered for path 'aglio' _Submodule 'ai_omniscope-v2-communication_sw' (git@github.com:AI-Gruppe/ai_omniscope-v2-communication_sw.git) registered for path 'ai_omniscope-v2-communicationsw' _Submodule 'cmake_helpers' (https://github.com/dominicpoeschko/cmake_helpers.git) registered for path 'cmakehelpers' Submodule 'imgui-filebrowser' (https://github.com/AirGuanZ/imgui-filebrowser.git) registered for path 'imgui-filebrowser' Cloning into '/home/arydev/Desktop/omniview/ImGuiInstance'... _Cloning into '/home/arydev/Desktop/omniview/aglio'... Cloning into '/home/arydev/Desktop/omniview/ai_omniscope-v2-communicationsw'... git@github.com: Permission denied (publickey). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.

_fatal: clone of 'git@github.com:AI-Gruppe/ai_omniscope-v2-communication_sw.git' into submodule path '/home/arydev/Desktop/omniview/ai_omniscope-v2-communication_sw' failed Failed to clone 'ai_omniscope-v2-communication_sw'. Retry scheduled Cloning into '/home/arydev/Desktop/omniview/cmake_helpers'... Cloning into '/home/arydev/Desktop/omniview/imgui-filebrowser'... Cloning into '/home/arydev/Desktop/omniview/ai_omniscope-v2-communicationsw'... git@github.com: Permission denied (publickey). fatal: Could not read from remote repository.

_Please make sure you have the correct access rights and the repository exists. fatal: clone of 'git@github.com:AI-Gruppe/ai_omniscope-v2-communication_sw.git' into submodule path '/home/arydev/Desktop/omniview/ai_omniscope-v2-communication_sw' failed Failed to clone 'ai_omniscope-v2-communicationsw' a second time, aborting .../omniview$

dominicpoeschko commented 10 months ago

You need access to https://github.com/AI-Gruppe/ai_omniscope-v2-communication_sw I think @bjoekeldude can give you access

MaxClerkwell commented 10 months ago

Can this be done without inviting him into the organization? Should this code be public, @dominicpoeschko @NP199, or is there a reason it is in our private repos?

MaxClerkwell commented 10 months ago

I added @R-Abbasi as an outside collaborator to this specific repo. This is just a temporary workaround and we need to find a way to precompile this as a library and make it available.

NP199 commented 10 months ago

We never specified if we should open source the code for the communication so we didn`t. We decide to postpone the decission to open source it or not @bjoekeldude.

MaxClerkwell commented 10 months ago

After a discussion last friday, it has been decided, that https://github.com/AI-Gruppe/ai_omniscope-v2-communication_sw will not be public at any point. There will be a serious effort in the last week of november to move the device handling out of this repo and make it available via a .dll or .so.

Anyway, this seems to be a bigger issue, than just a few lines of code. Since that will be needed for OmniView_2 as well, this has to be done at some point.

@odinthenerd, @dominicpoeschko and I will look into this end of november 2023, and decide on a timeline for this migration.

MaxClerkwell commented 3 months ago

@DonNagual will be working on a prototype implementation, starting at the end of this month.