Compile NIF using Port Compiler plugin - Githubissues

skunkwerks / snappy-erlang-nif

An Erlang NIF wrapper for Google's snappy compressor/decompressor

88 stars 64 forks source link

Compile NIF using Port Compiler plugin #26

Closed arcusfelis closed 5 years ago

arcusfelis commented 5 years ago

Hi,

Currently the library is compiled using Makefile. There are some issues with it:

The Makefile ignores use case, when Erlang is installed into a directory with whitespaces (i.e. wrong escaping)
erl calls in Makefile does not filter out SASL progress reports. So, ERTS_INCLUDE_DIR and other variables have some garbage in them on some Erlang versions (at least Erlang 19.3 on Mac OS X is affected).

This PR introduces the following changes:

Compile using pc when rebar3 is used.
rebar2 has builtin support for port_specs, so it would support the changes too.