skunkwerks / snappy-erlang-nif

An Erlang NIF wrapper for Google's snappy compressor/decompressor
88 stars 64 forks source link

Updated rebar.config to support R16 and Snappy 1.1.1 (test suite passes) #8

Closed pmembrey closed 10 years ago

pmembrey commented 10 years ago

Hi,

Bumping the supported versions to include R16.

I've also updated the source for Snappy to 1.1.1.

My C/C++ skills leave a lot to be desired, but the tests pass and as far as I can tell it's okay...

Cheers,

Pete

dch commented 10 years ago

@pmembrey LGTM, I get 1 warning which doesn't seem significant.

1 file changed, 1 insertion(+), 1 deletion(-)
🌈  dch@akai snappy-erlang-nif % make                                                          master✭
./rebar compile
==> snappy-erlang-nif (compile)
ERROR: OTP release 17 does not match required regex R13B04|R14|R15|R16|17.
make: *** [snappy] Error 1
🌈  dch@akai snappy-erlang-nif % vi rebar.config                                               master✭
🌈  dch@akai snappy-erlang-nif % make                                                        master✭  ✭
🌈  dch@akai snappy-erlang-nif % git fix                                                     master✭  ✭
[master ee2b726] rebar: add OTP 17.0 support
 1 file changed, 1 insertion(+), 1 deletion(-)
🌈  dch@akai snappy-erlang-nif % make                                                          master✭
./rebar compile
==> snappy-erlang-nif (compile)
Compiled src/snappy.erl
Compiling c_src/snappy_nif.cc
Compiling c_src/snappy/snappy-sinksource.cc
Compiling c_src/snappy/snappy-stubs-internal.cc
Compiling c_src/snappy/snappy.cc

If you update rebar.config to {require_otp_vsn, "R13B04|R14|R15|R16|17"}. this works for R16 and the upcoming R17 as well.

tyvm!