Closed pmembrey closed 10 years ago
@pmembrey LGTM, I get 1 warning which doesn't seem significant.
1 file changed, 1 insertion(+), 1 deletion(-)
🌈 dch@akai snappy-erlang-nif % make masterâœ
./rebar compile
==> snappy-erlang-nif (compile)
ERROR: OTP release 17 does not match required regex R13B04|R14|R15|R16|17.
make: *** [snappy] Error 1
🌈 dch@akai snappy-erlang-nif % vi rebar.config masterâœ
🌈 dch@akai snappy-erlang-nif % make master✠âœ
🌈 dch@akai snappy-erlang-nif % git fix master✠âœ
[master ee2b726] rebar: add OTP 17.0 support
1 file changed, 1 insertion(+), 1 deletion(-)
🌈 dch@akai snappy-erlang-nif % make masterâœ
./rebar compile
==> snappy-erlang-nif (compile)
Compiled src/snappy.erl
Compiling c_src/snappy_nif.cc
Compiling c_src/snappy/snappy-sinksource.cc
Compiling c_src/snappy/snappy-stubs-internal.cc
Compiling c_src/snappy/snappy.cc
If you update rebar.config
to {require_otp_vsn, "R13B04|R14|R15|R16|17"}.
this works for R16 and the upcoming R17 as well.
tyvm!
Hi,
Bumping the supported versions to include R16.
I've also updated the source for Snappy to 1.1.1.
My C/C++ skills leave a lot to be desired, but the tests pass and as far as I can tell it's okay...
Cheers,
Pete