search

skupperproject / skewer

A library for documenting and testing Skupper examples
Apache License 2.0
2 stars 2 forks source link

test-external for scenarios other than east/west #1

Closed pwright closed 2 years ago

pwright commented 2 years ago

If you want to create an example for any number of sites other than 2 (east, west), and you want to test using external clusters, you need to explicitly list those sites in the .planofile, for example, if you want to test a four site example, you might list:

@command
def test_external(app, west_kubeconfig, east_kubeconfig, north_kubeconfig, south_kubeconfig):
    """
    Test the example against external clusters
    """
    generate_readme("skewer.yaml", make_temp_file())
    run_steps_external("skewer.yaml", west=west_kubeconfig, east=east_kubeconfig, north=north_kubeconfig, south=south_kubeconfig)

@ssorj am I correct, and is this best addressed by putting the text above into README?

ssorj commented 2 years ago

@pwright yes, you are correct. I'll add that to the readme.

ssorj commented 2 years ago

I've now changed the run-external command to take a positional list of kubeconfigs. They are applied in order to the sites in the supplied skewer.yaml. The default implementation should work without being overridden, so I hope you can just use the symlinked .planofile and not create your own copy.

https://github.com/skupperproject/skewer/blob/e29aefebc9db61cba3687d55c2f416a0f7234959/config/.planofile#L49-L54