search

skupperproject / skupper-router

An application-layer router for Skupper networks
https://skupper.io
Apache License 2.0
14 stars 18 forks source link

Use packit for upstream RPMs #1013

Open jiridanek opened 1 year ago

jiridanek commented 1 year ago

https://packit.dev/docs/guide/

This appears to be the future of upstream RPM building. Currently used rpkg tooling seems to be inferior to this.

There is lots of outreach around the tool happening right now

For engaging external audience there are two opportunities right after:

jiridanek commented 1 year ago

See https://packit.dev/posts/2022-features/ for firehose-style overview of what this can do.

Example of the PR checks in action are at https://github.com/skupperproject/skupper-router/pull/1014, which triggered https://copr.fedorainfracloud.org/coprs/packit/skupperproject-skupper-router-1014/build/5705222/ which shows in the packit console as jobs https://dashboard.packit.dev/results/copr-builds/677809 and others (liked from the PR)

jiridanek commented 1 year ago

Dump of the rpkg version of .packit.yaml, for future reference

#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

# See the documentation for more information:
# https://packit.dev/docs/configuration/

# https://packit.dev/docs/configuration/#top-level-keys
upstream_project_url: https://github.com/skupperproject/skupper-router
issue_repository: https://github.com/skupperproject/skupper-router

specfile_path: skupper-router.spec
srpm_build_deps: [rpkg]
actions:
  post-upstream-clone:
    # HACK: spec must be next to the generated tarball; https://github.com/packit/packit/issues/1637
    - cp packaging/skupper-router.spec.rpkg .
    - rpkg srpm --outdir ./
  fix-spec-file:
    - bash packaging/.packit.sh

# add or remove files that should be synced
files_to_sync:
  - .packit.yaml
  - src: packaging/skupper-router.spec.rpkg
    dest: systemd.spec

# name in upstream package repository/registry (e.g. in PyPI)
upstream_package_name: skupper-router
# downstream (Fedora) RPM package name
downstream_package_name: skupper-router

jobs:
  # run build/unit tests on some interesting architectures
  - job: copr_build
    trigger: pull_request
    targets:
      # big-endian
      - fedora-development-s390x

  - job: tests
    trigger: pull_request
    targets:
      - fedora-stable
      - fedora-development
# This script handles any custom processing of the spec file generated using the `post-upstream-clone`
# action and gets used by the fix-spec-file action in .packit.yaml.

# Inspiration taken from https://github.com/containers/skopeo/blob/main/.packit.sh

set -eo pipefail

PROJECT=skupper-router

# RPM Spec modifications

# Version should be accepted by python3 -c 'import packaging.version; print(packaging.version.parse("0.0.0.3-git"))'
sed -i "s/^Version:.*/Version: $PACKIT_PROJECT_VERSION/" ${PROJECT}.spec

# Update Release in spec with Packit's release envvar
sed -i "s/^Release:.*/Release: $PACKIT_RPMSPEC_RELEASE%{?dist}/" ${PROJECT}.spec