search

skupperproject / skupper-router

An application-layer router for Skupper networks
https://skupper.io
Apache License 2.0
14 stars 18 forks source link

Fixes #1453: Directly install podman of using brew #1454

Closed ganeshmurthy closed 5 months ago

codecov[bot] commented 5 months ago

Codecov Report

Merging #1454 (428ae26) into main (985f4c3) will increase coverage by 0.0%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1454 +/- ## ===================================== Coverage 78.1% 78.1% ===================================== Files 246 246 Lines 63951 63952 +1 Branches 6103 6092 -11 ===================================== + Hits 49991 49997 +6 + Misses 11195 11190 -5 Partials 2765 2765 ``` | [Flag](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1454/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | Coverage Δ | | |---|---|---| | [pysystemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1454/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `87.6% <ø> (-0.1%)` | :arrow_down: | | [systemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1454/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `71.0% <ø> (+<0.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1454/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1454/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `78.1% <ø> (+<0.1%)` | :arrow_up: | | [systemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1454/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `78.1% <ø> (+<0.1%)` | :arrow_up: |
ganeshmurthy commented 5 months ago

it seems to work; there's not arguing with "works"

I copied this code directly from @fgiorgetti https://github.com/skupperproject/skupper/blob/659023da41a6cda8b41c71e4cb34a6a4cb398b8c/.circleci/config.yml#L314C1-L335

fgiorgetti commented 5 months ago

@ganeshmurthy maybe on an upcoming PR, you could turn this into a local action.

ganeshmurthy commented 5 months ago

@ganeshmurthy maybe on an upcoming PR, you could turn this into a local action.

You mean create a custom action that all these scripts can then use ?