search

skupperproject / skupper-router

An application-layer router for Skupper networks
https://skupper.io
Apache License 2.0
14 stars 18 forks source link

Fixes #1465: End the listener vanflow record when the listener is del… #1467

Closed ganeshmurthy closed 4 months ago

ganeshmurthy commented 4 months ago

…eted and not wait until the last connection on that listener is deleted

ganeshmurthy commented 4 months ago

Patch looks good to me. Can @fgiorgetti validate that it fixes the issue he found?

I talked to @fgiorgetti about testing. He wants the PR to be committed to main and he will test immediately. I will go ahead and merge this and if it does not fix the issue, we will revert immediately.

fgiorgetti commented 4 months ago

@ganeshmurthy @kgiusti I have our CI running for a new PR which is supposed to validate it.

fgiorgetti commented 4 months ago

@ganeshmurthy @kgiusti That CI test is now passing, I have also confirmed manually that the collector is receiving the appropriate flow record to terminate the listener. Thank you!

ganeshmurthy commented 4 months ago

@ganeshmurthy @kgiusti That CI test is now passing, I have also confirmed manually that the collector is receiving the appropriate flow record to terminate the listener. Thank you!

@fgiorgetti thank you very much for testing