skupperproject / skupper-router

An application-layer router for Skupper networks
https://skupper.io
Apache License 2.0
14 stars 18 forks source link

Issue #1494: add verbose TLS logging to diagnose stall #1500

Closed kgiusti closed 4 months ago

kgiusti commented 4 months ago

This does not solve the issue. Additional logging will help us root cause the issue. This commit may be reverted after #1494 is resolved for performance improvement.

ganeshmurthy commented 4 months ago

Since TLS is meant to go only over TCP and this adaptor tls module will not be used by any other adaptor, can the tls->log_module be replaced with LOG_TCP_ADAPTOR or perhaps introduce something like a LOG_TCP_TLS log module and the calls to qd_log_impl() be replaced with a simple qd_log()?

This above comment is unrelated to this PR but I just had that thought. This PR is ready to go.