search

skupperproject / skupper-router

An application-layer router for Skupper networks
https://skupper.io
Apache License 2.0
14 stars 18 forks source link

Fixes #1507: suppress libwebsocket logging races and update tests #1524

Closed kgiusti closed 3 months ago

kgiusti commented 3 months ago

Best I can tell the race is due to debug logging done during the supposedly thread safe call to lws_cancel_service().

It looks like the ubuntu build of libwebsockets may have enabled a static-scoped log buffer used by the debug logging, and lws_cancel_service() is issuing a debug log message.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.7%. Comparing base (1b1d4b9) to head (eb1d6ff). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1524 +/- ## ======================================= - Coverage 63.0% 62.7% -0.4% ======================================= Files 214 217 +3 Lines 51857 52685 +828 Branches 5986 6072 +86 ======================================= + Hits 32681 33040 +359 - Misses 16966 17410 +444 - Partials 2210 2235 +25 ``` | [Flag](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1524/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | Coverage Δ | | |---|---|---| | [pysystemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1524/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `77.4% <100.0%> (-0.8%)` | :arrow_down: | | [systemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1524/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `56.0% <ø> (-0.1%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1524/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `62.7% <39.9%> (-0.4%)` | :arrow_down: | | [systemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1524/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `62.7% <39.9%> (-0.4%)` | :arrow_down: |
ganeshmurthy commented 3 months ago

ALL TEST PASS !!! Great work !