search

skupperproject / skupper-router

An application-layer router for Skupper networks
https://skupper.io
Apache License 2.0
14 stars 18 forks source link

Fixes #1536: Removed unnecessary check for n >= 0 #1537

Closed ganeshmurthy closed 2 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.5%. Comparing base (1b1d4b9) to head (033d808). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1537 +/- ## ======================================== + Coverage 63.0% 77.5% +14.5% ======================================== Files 214 65 -149 Lines 51857 16389 -35468 Branches 5986 0 -5986 ======================================== - Hits 32681 12705 -19976 + Misses 16966 3684 -13282 + Partials 2210 0 -2210 ``` | [Flag](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1537/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | Coverage Δ | | |---|---|---| | [pysystemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `77.5% <ø> (-0.8%)` | :arrow_down: | | [systemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1537/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1537/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `77.5% <31.5%> (+14.5%)` | :arrow_up: | | [systemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1537/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `77.5% <31.5%> (-0.8%)` | :arrow_down: |
jiridanek commented 2 weeks ago

Took a look at the failing CI and reported

jiridanek commented 2 weeks ago

superseded by