search

skupperproject / skupper-router

An application-layer router for Skupper networks
https://skupper.io
Apache License 2.0
14 stars 18 forks source link

Fixes #1456 - Implemented the administrative ACCESS_POINT and LINK #1540

Closed kgiusti closed 1 week ago

kgiusti commented 1 week ago

This also separates the closure-of-all-connections from the freeing of the server module so that connections can be closed at an earlier point of the shutdown sequence.

This also adds accepted-connections to the listener reference counts for a more orderly freeing of resources.

Original work by Ted Ross. Ported to amqp adaptor and obfuscated by kgiusti

kgiusti commented 1 week ago

As part of this port I also took the opportunity to "clean up" the code used by the connectors/listeners for creating qd_connection_t's. Removed some legacy dead codepaths and updated function names that were originally associated with the server module.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 86.40000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.6%. Comparing base (1b1d4b9) to head (c1f1c96). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1540 +/- ## ======================================= + Coverage 63.0% 70.6% +7.6% ======================================= Files 214 210 -4 Lines 51857 54610 +2753 Branches 5986 5962 -24 ======================================= + Hits 32681 38576 +5895 + Misses 16966 13413 -3553 - Partials 2210 2621 +411 ``` | [Flag](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | Coverage Δ | | |---|---|---| | [pysystemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `81.9% <72.5%> (+3.6%)` | :arrow_up: | | [systemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `64.8% <95.9%> (+8.7%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1540/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1540/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `70.6% <76.9%> (+7.6%)` | :arrow_up: | | [systemtests](https://app.codecov.io/gh/skupperproject/skupper-router/pull/1540/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=skupperproject) | `70.6% <76.9%> (+7.6%)` | :arrow_up: |