skupperproject / skupper

Skupper is an implementation of a Virtual Application Network, enabling rich hybrid cloud communication.
http://skupper.io
Apache License 2.0
579 stars 70 forks source link

Tokens created with type cert have a static name #1154

Open fgiorgetti opened 1 year ago

fgiorgetti commented 1 year ago

If a token is created using skupper token create --token-type cert my-token.yaml, skupper is setting the Secret name to skupper. With that if you generate multiple secrets, for different clusters, and apply them all to a given namespace, only one link will be defined, as secret skupper will be replaced.

It would be good to use a distinct secret name, probably based on the site-id.

grs commented 10 months ago

Note that there is a --name option that can be used to override the default. That said I would accept the current choice of default is not necessarily optimal.