CRD revisions - Githubissues

skupperproject / skupper

Skupper is an implementation of a Virtual Application Network, enabling rich hybrid cloud communication.

http://skupper.io

Apache License 2.0

595 stars 74 forks source link

CRD revisions #1745

Closed grs closed 3 weeks ago

grs commented 4 weeks ago

change version to v2alpha1
use settings consistently for all resources
add message field to status and use existing status field as machine readable state description (Ready, Pending or Error)

fgiorgetti commented 4 weeks ago

The following yaml files are adding ownerReferences using v1alpha1:

pkg/kube/site/resources/skupper-router-deployment.yaml
pkg/kube/site/resources/skupper-router-local-service.yaml

grs commented 4 weeks ago

The following yaml files are adding ownerReferences using v1alpha1:
* `pkg/kube/site/resources/skupper-router-deployment.yaml`

* `pkg/kube/site/resources/skupper-router-local-service.yaml`

Well spotted! Fixed now.

grs commented 4 weeks ago

./cmd/network-console-collector/* has a different "v1alpha1" (the collector api version.) Could you reset everything under there and patch the yaml resources?

Oops, sorry! Done now.