config sync changes and rename

skupperproject / skupper

Skupper is an implementation of a Virtual Application Network, enabling rich hybrid cloud communication.

http://skupper.io

Apache License 2.0

595 stars 74 forks source link

config sync changes and rename #1754

Closed grs closed 2 weeks ago

grs commented 3 weeks ago

add init mode and use that in init-container to fix #1716
rename image to kube-adaptor to reflect its wider role

ssorj commented 3 weeks ago

I like the name kube-adaptor, but so far I think "router-adaptor" is more helpful in the context of its sibling binaries and images. I came to this conclusion by thinking about how the names would look in the source tree and the quay org.

Screenshot from 2024-10-30 06-39-22

Screenshot from 2024-10-30 06-42-26

nluaces commented 2 weeks ago

Helm chart needs to be updated as well: https://github.com/skupperproject/skupper/blob/81a9f91f61a8c95510e14abe869c82aa29aa25e1/deployments/helm/values.yaml#L3 https://github.com/skupperproject/skupper/blob/81a9f91f61a8c95510e14abe869c82aa29aa25e1/deployments/helm/templates/deploy_controller.yaml#L241

grs commented 2 weeks ago

I've separated the fix for #1716 from any naming change here (#1769) to get that in while the final name is debated. Hence closing this.