search

skupperproject / skupper

Skupper is an implementation of a Virtual Application Network, enabling rich hybrid cloud communication.
http://skupper.io
Apache License 2.0
579 stars 70 forks source link

Site controller - skupper update check only relies on skupper-internal configmap version value. #943

Open rmallam opened 1 year ago

rmallam commented 1 year ago

Hi,

I deployed skupper using helm and made a human error which resulted in a wrong value in skupper-internal configmap

skrouterd.json: |- [ [ "router", { "id": "ddtb-channelapp-e2e4-medium-di1001-${HOSTNAME}", "mode": "interior", "helloMaxAgeSeconds": "3", "metadata": "{\"id\":\"c9f6162d-140d-4e74-a9bb-eacc4e21ec3c\",\"version\":\"1.1.1\"}" }

the version value above was set to 2.1.0 and skupper site controller started throwing an error showing, the skupper version is higher than the controller version. Though this was not causing any problem with the entire functionality, it was confusing. Could we change the version check to someother place where we cant change it manually.

grs commented 1 year ago

The version there is not indicating the version of the router component but of the configuration itself. As skupper evolves the configuration changes. The version here is simply a way to understand which version of skupper created that config.