skuschel / postpic

The open-source particle-in-cell post-processor.
GNU General Public License v3.0
65 stars 27 forks source link

add new default species for QED module. #250

Closed MerlinPendragon closed 4 years ago

MerlinPendragon commented 4 years ago

Hi guys, I simply added 3 more default species for QED module of EPOCH. But the scalar property should change for photon since its mass equals 0. Any idea?

skuschel commented 4 years ago

Hi @MerlinPendragon thanks a lot for your contribution. I agree that these default names are not captured, but probably used within the QED context. Regarding the scalar property of photons: I took a quick look into the epoch manual but didnt see how the photon energies are written and what properties you will need to access. Maybe you can explain and we can work out a solution.

skuschel commented 4 years ago

I will merge this as its a change in itself. Maybe you like to open an issue to disucuss how other photon properties can be accessed?

skuschel commented 4 years ago

just a hint: Github doesnt understand that your commit was done by you as a github user. If you like to be listed under https://github.com/skuschel/postpic/graphs/contributors you will need to link your email adress from your gitconfig to your github account. :)

MerlinPendragon commented 4 years ago

Thank you! It's mainly about the energy of photon. I will probably add a new scalar property for photon and open another pull request.

skuschel commented 4 years ago

Sounds good. I hope we can find something which will be equally useful for particles and photons.