blastwave
commented
3 years ago Easy enough to hack past and then we get disaster :
alpha $ diff -u ./src/util/temp_file.cc.orig ./src/util/temp_file.cc
--- ./src/util/temp_file.cc.orig Thu Mar 7 13:15:11 2019
+++ ./src/util/temp_file.cc Mon Mar 29 00:38:19 2021
@@ -79,10 +79,20 @@
bool ok = false;
src = fopen(srcname, "r");
- if (!src) goto end;
+ if (!src) {
+ if (src) fclose(src);
+ if (dst) fclose(dst);
+ UNLINK(ok ? srcname : dstname);
+ return ok;
+ }
dst = fopen(dstname, "w");
- if (!dst) goto end;
+ if (!dst) {
+ if (src) fclose(src);
+ if (dst) fclose(dst);
+ UNLINK(ok ? srcname : dstname);
+ return ok;
+ }
static const size_t BLK = 4096;
char buf[BLK];
@@ -93,11 +103,6 @@
}
ok = true;
-end:
- if (src) fclose(src);
- if (dst) fclose(dst);
- UNLINK(ok ? srcname : dstname);
-
return ok;
}
/opt/bw/bin/bash ./libtool --tag=CXX --mode=link /opt/developerstudio12.6/bin/CC -W -Wall -Wextra -Weffc++ -pedantic -Wformat=2 -Wredundant-decls -Wsuggest-attribute=format -Wconversion -Wsign-conversion -Werror=return-type -O2 -Weverything -Wno-unknown-warning-option -Wno-reserved-id-macro -Wno-padded -Wno-old-style-cast -Wno-nested-anon-types -Wno-global-constructors -Wno-shadow-field-in-constructor -Wno-undefined-func-template -DRE2C_STDLIB_DIR='"/opt/bw/share/re2c/stdlib/"' -DRE2C_DEBUG -std=c++11 -xO0 -g -dalign -erroff=%none -errtags=yes -ftrap=%none -xcode=pic32 -m64 -xbuiltin=%none -xarch=sparc -xdepend=no -xregs=no%appl -D_POSIX_PTHREAD_SEMANTICS -D_LARGEFILE64_SOURCE -D_TS_ERRNO -module -no-undefined -L/opt/bw/lib -R/opt/bw/lib -o libre2c.la -rpath /opt/bw/lib lib/libre2c_la-regcomp.lo lib/libre2c_la-regexec.lo lib/libre2c_la-regexec_dfa.lo lib/libre2c_la-regexec_dfa_regless.lo lib/libre2c_la-regexec_nfa_leftmost.lo lib/libre2c_la-regexec_nfa_leftmost_trie.lo lib/libre2c_la-regexec_nfa_posix.lo lib/libre2c_la-regexec_nfa_posix_trie.lo lib/libre2c_la-regexec_nfa_posix_backward.lo lib/libre2c_la-regexec_nfa_posix_kuklewicz.lo lib/libre2c_la-regfree.lo lib/libre2c_la-stubs.lo src/parse/libre2c_la-ast.lo src/parse/libre2c_la-unescape.lo src/options/libre2c_la-opt.lo src/cfg/libre2c_la-cfg.lo src/cfg/libre2c_la-compact.lo src/cfg/libre2c_la-dce.lo src/cfg/libre2c_la-freeze.lo src/cfg/libre2c_la-interfere.lo src/cfg/libre2c_la-liveanal.lo src/cfg/libre2c_la-normalize.lo src/cfg/libre2c_la-optimize.lo src/cfg/libre2c_la-rename.lo src/cfg/libre2c_la-varalloc.lo src/dfa/libre2c_la-closure.lo src/debug/libre2c_la-dump_adfa.lo src/debug/libre2c_la-dump_cfg.lo src/debug/libre2c_la-dump_dfa.lo src/debug/libre2c_la-dump_dfa_tree.lo src/debug/libre2c_la-dump_interf.lo src/debug/libre2c_la-dump_nfa.lo src/dfa/libre2c_la-dead_rules.lo src/dfa/libre2c_la-determinization.lo src/dfa/libre2c_la-fallback_tags.lo src/dfa/libre2c_la-fillpoints.lo src/dfa/libre2c_la-find_state.lo src/dfa/libre2c_la-minimization.lo src/dfa/libre2c_la-stacmd.lo src/dfa/libre2c_la-tagver_table.lo src/dfa/libre2c_la-tcmd.lo src/nfa/libre2c_la-estimate_size.lo src/nfa/libre2c_la-re_to_nfa.lo src/encoding/libre2c_la-enc.lo src/encoding/libre2c_la-range_suffix.lo src/encoding/ebcdic/libre2c_la-ebcdic_regexp.lo src/encoding/utf16/libre2c_la-utf16.lo src/encoding/utf16/libre2c_la-utf16_regexp.lo src/encoding/utf8/libre2c_la-utf8.lo src/encoding/utf8/libre2c_la-utf8_regexp.lo src/msg/libre2c_la-msg.lo src/msg/libre2c_la-warn.lo src/regexp/libre2c_la-ast_to_re.lo src/regexp/libre2c_la-default_tags.lo src/regexp/libre2c_la-fixed_tags.lo src/regexp/libre2c_la-nullable.lo src/regexp/libre2c_la-rule.lo src/regexp/libre2c_la-split_charset.lo src/regexp/libre2c_la-tag.lo src/skeleton/libre2c_la-control_flow.lo src/skeleton/libre2c_la-maxpath.lo src/skeleton/libre2c_la-skeleton.lo src/util/libre2c_la-range.lo src/util/libre2c_la-s_to_n32_unsafe.lo lib/libre2c_la-lex.lo lib/libre2c_la-parse.lo src/msg/libre2c_la-ver_to_vernum.lo
libtool: link: /opt/developerstudio12.6/bin/CC -G -zdefs -hlibre2c.so.0 -o .libs/libre2c.so.0.0.0 lib/.libs/libre2c_la-regcomp.o lib/.libs/libre2c_la-regexec.o lib/.libs/libre2c_la-regexec_dfa.o lib/.libs/libre2c_la-regexec_dfa_regless.o lib/.libs/libre2c_la-regexec_nfa_leftmost.o lib/.libs/libre2c_la-regexec_nfa_leftmost_trie.o lib/.libs/libre2c_la-regexec_nfa_posix.o lib/.libs/libre2c_la-regexec_nfa_posix_trie.o lib/.libs/libre2c_la-regexec_nfa_posix_backward.o lib/.libs/libre2c_la-regexec_nfa_posix_kuklewicz.o lib/.libs/libre2c_la-regfree.o lib/.libs/libre2c_la-stubs.o src/parse/.libs/libre2c_la-ast.o src/parse/.libs/libre2c_la-unescape.o src/options/.libs/libre2c_la-opt.o src/cfg/.libs/libre2c_la-cfg.o src/cfg/.libs/libre2c_la-compact.o src/cfg/.libs/libre2c_la-dce.o src/cfg/.libs/libre2c_la-freeze.o src/cfg/.libs/libre2c_la-interfere.o src/cfg/.libs/libre2c_la-liveanal.o src/cfg/.libs/libre2c_la-normalize.o src/cfg/.libs/libre2c_la-optimize.o src/cfg/.libs/libre2c_la-rename.o src/cfg/.libs/libre2c_la-varalloc.o src/dfa/.libs/libre2c_la-closure.o src/debug/.libs/libre2c_la-dump_adfa.o src/debug/.libs/libre2c_la-dump_cfg.o src/debug/.libs/libre2c_la-dump_dfa.o src/debug/.libs/libre2c_la-dump_dfa_tree.o src/debug/.libs/libre2c_la-dump_interf.o src/debug/.libs/libre2c_la-dump_nfa.o src/dfa/.libs/libre2c_la-dead_rules.o src/dfa/.libs/libre2c_la-determinization.o src/dfa/.libs/libre2c_la-fallback_tags.o src/dfa/.libs/libre2c_la-fillpoints.o src/dfa/.libs/libre2c_la-find_state.o src/dfa/.libs/libre2c_la-minimization.o src/dfa/.libs/libre2c_la-stacmd.o src/dfa/.libs/libre2c_la-tagver_table.o src/dfa/.libs/libre2c_la-tcmd.o src/nfa/.libs/libre2c_la-estimate_size.o src/nfa/.libs/libre2c_la-re_to_nfa.o src/encoding/.libs/libre2c_la-enc.o src/encoding/.libs/libre2c_la-range_suffix.o src/encoding/ebcdic/.libs/libre2c_la-ebcdic_regexp.o src/encoding/utf16/.libs/libre2c_la-utf16.o src/encoding/utf16/.libs/libre2c_la-utf16_regexp.o src/encoding/utf8/.libs/libre2c_la-utf8.o src/encoding/utf8/.libs/libre2c_la-utf8_regexp.o src/msg/.libs/libre2c_la-msg.o src/msg/.libs/libre2c_la-warn.o src/regexp/.libs/libre2c_la-ast_to_re.o src/regexp/.libs/libre2c_la-default_tags.o src/regexp/.libs/libre2c_la-fixed_tags.o src/regexp/.libs/libre2c_la-nullable.o src/regexp/.libs/libre2c_la-rule.o src/regexp/.libs/libre2c_la-split_charset.o src/regexp/.libs/libre2c_la-tag.o src/skeleton/.libs/libre2c_la-control_flow.o src/skeleton/.libs/libre2c_la-maxpath.o src/skeleton/.libs/libre2c_la-skeleton.o src/util/.libs/libre2c_la-range.o src/util/.libs/libre2c_la-s_to_n32_unsafe.o lib/.libs/libre2c_la-lex.o lib/.libs/libre2c_la-parse.o src/msg/.libs/libre2c_la-ver_to_vernum.o -R/opt/bw/lib -L/opt/bw/lib -lc -O2 -g -m64 -xarch=sparc
Undefined first referenced
symbol in file
std::string::basic_string(const std::string &) src/parse/.libs/libre2c_la-ast.o
std::string::operator=(const std::string &) src/options/.libs/libre2c_la-opt.o
operator new[](unsigned long) lib/.libs/libre2c_la-regcomp.o
operator new(unsigned long) lib/.libs/libre2c_la-regcomp.o
std::__throw_out_of_range_fmt(const char*, ...) src/debug/.libs/libre2c_la-dump_dfa_tree.o
std::string::compare(const std::string &)const src/regexp/.libs/libre2c_la-ast_to_re.o
std::string::append(const char*) src/options/.libs/libre2c_la-opt.o
std::string::append(const char*, unsigned long) src/options/.libs/libre2c_la-opt.o
std::string::append(const std::string &) src/options/.libs/libre2c_la-opt.o
std::string::_M_rep()const src/regexp/.libs/libre2c_la-rule.o
std::string::push_back(char) src/options/.libs/libre2c_la-opt.o
std::string::operator+=(const std::string &) src/msg/.libs/libre2c_la-msg.o
std::__throw_length_error(const char*) lib/.libs/libre2c_la-regcomp.o
__cxa_guard_release src/regexp/.libs/libre2c_la-fixed_tags.o
std::string::basic_string() src/msg/.libs/libre2c_la-msg.o
std::string::~basic_string() lib/.libs/libre2c_la-regcomp.o
__atomic_fetch_add_8 lib/.libs/libre2c_la-regcomp.o
__cxxabiv1::zero_ints(void*, unsigned long) src/msg/.libs/libre2c_la-warn.o
__cxa_end_catch lib/.libs/libre2c_la-regcomp.o
std::string::_M_data()const src/regexp/.libs/libre2c_la-ast_to_re.o
__cxa_begin_catch lib/.libs/libre2c_la-regcomp.o
std::string::empty()const src/options/.libs/libre2c_la-opt.o
std::allocator<char>::allocator(const std::allocator<char>&) lib/.libs/libre2c_la-regcomp.o
std::_Rb_tree_increment(std::_Rb_tree_node_base*) src/dfa/.libs/libre2c_la-closure.o
operator delete[](void*) lib/.libs/libre2c_la-regexec_nfa_posix_backward.o
operator delete(void*) lib/.libs/libre2c_la-regcomp.o
std::string::basic_string(const char*, const std::allocator<char>&) lib/.libs/libre2c_la-regcomp.o
std::string::rbegin() src/options/.libs/libre2c_la-opt.o
__SUNW_ABIG3_cpp_personality lib/.libs/libre2c_la-regcomp.o
std::string::_Rep::_S_empty_rep_storage lib/.libs/libre2c_la-regcomp.o
[Hint: static member std::string::_Rep::_S_empty_rep_storage must be defined in the program]
std::string::compare(const char*)const src/regexp/.libs/libre2c_la-nullable.o
std::string::basic_string(const char*, unsigned long, const std::allocator<char>&) src/msg/.libs/libre2c_la-ver_to_vernum.o
std::__throw_bad_alloc() lib/.libs/libre2c_la-regcomp.o
_Unwind_Resume lib/.libs/libre2c_la-regcomp.o
__cxxabiv1::register_exit_code(void (*)(void)extern"C") src/parse/.libs/libre2c_la-ast.o
std::string::operator=(const char*) src/options/.libs/libre2c_la-opt.o
std::string::operator=(std::string &&) src/options/.libs/libre2c_la-opt.o
std::allocator<char>::~allocator() lib/.libs/libre2c_la-regcomp.o
std::allocator<char>::~allocator() lib/.libs/libre2c_la-regfree.o
std::allocator<char>::allocator() lib/.libs/libre2c_la-regcomp.o
std::terminate() lib/.libs/libre2c_la-regcomp.o
std::_Rb_tree_increment(const std::_Rb_tree_node_base*) lib/.libs/libre2c_la-regfree.o
std::_Rb_tree_decrement(const std::_Rb_tree_node_base*) src/regexp/.libs/libre2c_la-split_charset.o
std::string::operator+=(const char*) src/msg/.libs/libre2c_la-msg.o
std::string::reserve(unsigned long) src/options/.libs/libre2c_la-opt.o
__cxxabiv1::zero_ptrs(void*, unsigned long) src/dfa/.libs/libre2c_la-dead_rules.o
__cxxabiv1::vector_del(void*, unsigned long, void (*)(void*)) src/cfg/.libs/libre2c_la-interfere.o
std::string::_Rep::_M_dispose(const std::allocator<char>&) src/regexp/.libs/libre2c_la-ast_to_re.o
std::_Rb_tree_rebalance_for_erase(std::_Rb_tree_node_base*, std::_Rb_tree_node_base&) src/parse/.libs/libre2c_la-ast.o
std::string::_Rep::_M_destroy(const std::allocator<char>&) lib/.libs/libre2c_la-regcomp.o
__cxa_guard_acquire src/regexp/.libs/libre2c_la-fixed_tags.o
std::_Rb_tree_insert_and_rebalance(bool, std::_Rb_tree_node_base*, std::_Rb_tree_node_base*, std::_Rb_tree_node_base&) lib/.libs/libre2c_la-regcomp.o
std::string::_S_compare(unsigned long, unsigned long) src/regexp/.libs/libre2c_la-ast_to_re.o
__cxa_rethrow lib/.libs/libre2c_la-regcomp.o
__cxxabiv1::vector_new(void*, unsigned long, unsigned long, void (*)(void*), void (*)(void*)) src/cfg/.libs/libre2c_la-interfere.o
std::string::get_allocator()const src/regexp/.libs/libre2c_la-ast_to_re.o
std::string::data()const src/regexp/.libs/libre2c_la-ast_to_re.o
std::_Rb_tree_decrement(std::_Rb_tree_node_base*) lib/.libs/libre2c_la-regcomp.o
std::string::size()const src/regexp/.libs/libre2c_la-ast_to_re.o
std::string::_Rep::_S_empty_rep() lib/.libs/libre2c_la-regcomp.o
ld: fatal: symbol referencing errors. No output written to .libs/libre2c.so.0.0.0
gmake[2]: *** [Makefile:2113: libre2c.la] Error 2
gmake[2]: Leaving directory '/export/home/dclarke/foo/re2c-2.1.1'
gmake[1]: *** [Makefile:4518: all-recursive] Error 1
gmake[1]: Leaving directory '/export/home/dclarke/foo/re2c-2.1.1'
gmake: *** [Makefile:1721: all] Error 2
Well gee ... this is a mess.
Perhaps we don't build the lib? 
skvadrik
Sadly I can not provide a lot of input here however :