search

skvadrik / re2c

Lexer generator for C, C++, D, Go, Haskell, Java, JS, OCaml, Python, Rust, V and Zig.
https://re2c.org
Other
1.11k stars 173 forks source link

[Web playground] Add "Share" button. Add icons for the buttons. #499

Closed PolarGoose closed 1 week ago

PolarGoose commented 2 weeks ago

I have uncommented set -o xtrace line. Do we really want it to be commented out? Then, it is not clear what happens when scripts are run.

skvadrik commented 2 weeks ago

I have uncommented set -o xtrace line. Do we really want it to be commented out? Then, it is not clear what happens when scripts are run.

I'd prefer it commented out. The general rule for build scripts is to be silent or output only a few "this step is complete" messages on successful execution, and be verbose only in case of errors (and then keep verbosity scoped to the error). This way developers don't have to needlessly look at pages of text, trying to understand why it was printed and if it contains some errors/warnings that require attention. We keep to this rule of thumb in other re2c build /test scripts, build system, etc.

In particular, I run this script quite often when working on the docs, and I'd like to see as small output as possible when I focus on the content changes (not script changes). If you wish, you can add a --verbose option (or if you really prefer verbose by default, add a --quiet option).

FYI I added a few options to the sync script.

PolarGoose commented 2 weeks ago

I'd prefer it commented out.

Ok, np. If it is more convenient, then it is fine. I have commented it out like it was before.