skwasjer / IbanNet

C# .NET IBAN validator, parser, builder and generator
Apache License 2.0
119 stars 31 forks source link

Iban in an included country raise UnknownCountryCodeResult #107

Closed fredgl1 closed 1 year ago

fredgl1 commented 1 year ago

An IBAN from an included country raises an UnknownCountryCodeResult error.

For example Wallis & Futuna (WF) included in France (FR) WF9120041010050500013M02606 is not valid with IbanNet but is valid on https://bank-codes.fr/iban/validate/

skwasjer commented 1 year ago

Thanks for reporting, this is definitely a bug. Will have a look asap.

skwasjer commented 1 year ago

After further investigation, I do not believe that site is correct. I have reviewed different sources, all of those mention that included countries use the country code of the primary country, which in this case would be FR.

https://www.ecbs.org/iban/france-bank-account-number.html https://www.swift.com/standards/data-standards/iban-international-bank-account-number

French Guiana, French Polynesia, French Southern Territories, Guadeloupe, Martinique, Mayotte, New Caledonia, Réunion, Saint Barthélemy, Saint Martin (French part), Saint Pierre and Miquelon, and Wallis and Futuna Islands have their own ISO country code but use "FR" as their IBAN country code.

If you have different sources, I would be happy to review, but for the time being I will not make any chances with the confidence that this library implements the SWIFT registry correctly.

skwasjer commented 1 year ago

Closing due to inactivity, feel free to reopen with new info/sources and/or examples.