search

skwasjer / IbanNet

C# .NET IBAN validator, parser, builder and generator
Apache License 2.0
126 stars 31 forks source link

Add unit tests for bban validators #11

Closed Greybird closed 4 years ago

Greybird commented 4 years ago

Before adding new use cases, I decided to add unit tests for the implemented countries. Sometimes data is quite difficult to find. I used the below sources:

codecov-io commented 4 years ago

Codecov Report

Merging #11 into feature/bban will increase coverage by 0.62%. The diff coverage is 100%.

Impacted Files Coverage Δ
...ationalCheckDigits/NationalCheckDigitsValidator.cs 80% <ø> (ø) :arrow_up:
...ts/Calculators/Mod97From98CheckDigitsCalculator.cs 100% <100%> (ø)
...CheckDigits/NorwayMod11ValidatorDigitsValidator.cs 100% <100%> (ø)
...an/Validation/Rules/HasValidNationalCheckDigits.cs 92.1% <100%> (ø) :arrow_up:
...AndHerzegovinaMod97NationalCheckDigitsValidator.cs 100% <100%> (ø)
...heckDigits/Calculators/CinCheckDigitsCalculator.cs 100% <0%> (+15.78%) :arrow_up:
skwasjer commented 4 years ago

LGTM. Nit though, could you reformat using tabs? Mostly tabs are used but in some places there's spaces. I'll merge right after that.

skwasjer commented 4 years ago

WIP Feature request, see #7