search

skwasjer / IbanNet

C# .NET IBAN validator, parser, builder and generator
Apache License 2.0
119 stars 31 forks source link

NL file is added to compiled output #123

Closed Phoniexk closed 1 year ago

Phoniexk commented 1 year ago

With Release v5.7.1 you have added "nl" resx files.

On compilation (Debug / Release / Publish) this creates a folder "nl" with "IbanNet.resources.dll"...

I don't need "nl" resources and I also don't need any other resource files. If you add in future more language files, this will mess up compiled output with such files...

Please provide the resources in another way without adding additional files to the output.

skwasjer commented 1 year ago

While I understand where you are coming from, the inclusion of localization helps further adoption and convenience for the broader audience. Including resource satellite assemblies is common practice for projects that support a large target audience. I should not have to reinvent the wheel with a custom solution or add extra NuGet packages, per language and per IbanNet.* package mind you, just for localization purpose alone. IbanNet is not the only project to do so.

Besides that, the .NET SDK has an option to exclude (or rather opt-in to specific) satellite assemblies at 'your' end: https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#satelliteresourcelanguages

And if you are using an older MSBuild, then you can also write a custom post-build script to delete those folders.

Hope this helps!