skwasjer / IbanNet

C# .NET IBAN validator, parser, builder and generator
Apache License 2.0
119 stars 31 forks source link

ci: ensure SonarCloud can run in context of PR with repo secrets #161

Closed skwasjer closed 10 months ago

skwasjer commented 10 months ago

This change ensures we run SonarCloud analysis in context of PR, while having access to repo secrets. However, we must protect from outside PR's 'stealing' our secrets. This problem is solved by requiring external contribs/PR's to be manually approved before this workflow can run, via adding a minimum of 1 reviewer to environment protection rules on env 'external'.

This mechanism is described in this blog: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch