search

skwasjer / IbanNet

C# .NET IBAN validator, parser, builder and generator
Apache License 2.0
119 stars 31 forks source link

feat(localization): add german translation #172

Closed janro1 closed 9 months ago

janro1 commented 9 months ago

Hi @skwasjer, here is a small PR to add german localisation. I hope it fits like this.

codecov[bot] commented 9 months ago

Codecov Report

Merging #172 (44f0624) into main (e369380) will not change coverage. The diff coverage is n/a.

Additional details and impacted files
skwasjer commented 9 months ago

Hi @janro1, thanks. Can you add a spot check test case in each test project? Look for a test-file called LocalizationTests.cs

For example: https://github.com/skwasjer/IbanNet/blob/main/test/IbanNet.Tests/LocalizationTests.cs

janro1 commented 9 months ago

Hi @skwasjer, I've added the tests.

skwasjer commented 9 months ago

Thanks!

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

janro1 commented 8 months ago

@skwasjer could you maybe do a release with this included? My current project is waiting for the german localisation.

skwasjer commented 8 months ago

Should be available in about 30min: v5.12.0