search

skx / gobasic

A BASIC interpreter written in golang.
https://blog.steve.fi/tags/basic/
GNU General Public License v2.0
331 stars 27 forks source link

Update INPUT command to use embedded Reader #99

Closed andydotxyz closed 5 years ago

andydotxyz commented 5 years ago

Complete the move to embedded Reader/Writer Remove the test.v requirement to run the INPUT test

andydotxyz commented 5 years ago

Sorry I didn't notice that this was mostly addressed by you already oops! Maybe you can see if there is anything here you want and pull it out, otherwise just close it :)

andydotxyz commented 5 years ago

It looks like the main difference is that you still use fmt.Printf in the INPUT prompt

skx commented 5 years ago

It looks like the main difference is that you still use fmt.Printf in the INPUT prompt

That's a good observation. if you submitted a PR just for that I'd accept it. Otherwise I'll deal with it in the morning.

andydotxyz commented 5 years ago

Quite right - I will try and rebase my work so you don't have to unpick this all

andydotxyz commented 5 years ago

Replaced with #100