sky-map-team / stardroid

Sky Map (formerly Google Sky Map, open sourced in 2012)
https://play.google.com/store/apps/details?id=com.google.android.stardroid&hl=en
Apache License 2.0
936 stars 233 forks source link

Rigel in Centaurus should be Riger Kenttaurus #14

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Menu > Search > Centaurus
2. Go to Centaurus, you will find Rigel in Centaurus
3.

What is the expected output? What do you see instead?
The Rigel should be Riger Kenttaurus or Alpha Centauri

What version of the product are you using? On what operating system?
1.6.4

Please provide any additional information below.
The Chinese name is "南门二"

Original issue reported on code.google.com by john.h...@gmail.com on 19 Sep 2012 at 9:08

GoogleCodeExporter commented 9 years ago
One interesting thing to note is that in:

trunk/tools/src/com/google/android/stardroid/data/stars_R.ascii

there are the following lines:

    REMOVE_string_index: "Rigel Kentaurus A"
    string_index: R.string.rigel
  }
  REMOVE_name_ids: "Rigel Kentaurus A"
  name_ids: R.string.rigel

It seems the wrong string id is used for Rigel Kentaurus A, is should say(if I 
understand things correctly):

    REMOVE_string_index: "Rigel Kentaurus A"
    string_index: R.string.rigel_kentaurus_a
  }
  REMOVE_name_ids: "Rigel Kentaurus A"
  name_ids: R.string.rigel_kentaurus_a

Original comment by constant...@gmail.com on 25 Sep 2012 at 4:02

jaydeetay commented 8 years ago

Thanks for the bug report. This is now fixed in head. I added some extra synonyms too.

jaydeetay commented 8 years ago

Fixed in the 1.6.5+ releases.