search

sky-map-team / stardroid

Sky Map (formerly Google Sky Map, open sourced in 2012)
https://play.google.com/store/apps/details?id=com.google.android.stardroid&hl=en
Apache License 2.0
892 stars 231 forks source link

Menu items are in black text. #210

Open jaydeetay opened 6 years ago

jaydeetay commented 6 years ago

Suspect this was caused by the recent upgrade in targetApiLevel removing some shim we depended on.

jaydeetay commented 6 years ago

Might just be Android P on Pixel XL.

jaydeetay commented 6 years ago

OK, confirmed this is a Google issue that just affects P. Basically they did a clean up and explicitly nulled out some attributes that were 'falling through' from the material theme. Unfortunately they were needed. Fixed in https://android.googlesource.com/platform/frameworks/base/+/2fc8afab1ad302a9a44f5b89b38991a80436e953%5E%21/#F1

I think in the meantime release a "P" specific version of SkyMap that doesn't use the long-deprecated Holo theme is the safest thing to do. The right long term solution is to get off Holo.