search

sky-map-team / stardroid

Sky Map (formerly Google Sky Map, open sourced in 2012)
https://play.google.com/store/apps/details?id=com.google.android.stardroid&hl=en
Apache License 2.0
923 stars 232 forks source link

build_skymap.sh as part of the primary gradle #296

Open aayushsingla opened 5 years ago

aayushsingla commented 5 years ago

Summary: Android now supports protobuf plugin and running shellscript from the gradle. So, build_skymap.sh should be merged with gradle itself.

aayushsingla commented 5 years ago

@jaydeetay @barbeau I want to work on this issue. But, I have some doubts.

  1. We cannot build the complete project from scratch in every case like even when there is no change in Strings.xml file or source.proto. So how can we keep track of these files in gradle when building the complete project? I think implementing this issue will require some project structure changes, like shifting source.proto files and JavaSourceProto files. So shall I proceed with this issue?
barbeau commented 5 years ago

There are ways to execute tasks in Gradle only when files change, but given the work it would take to implement, debug, and review this as @jaydeetay said earlier it would probably be better to sink this effort into architecting and implementing a new system to manage the data.

aayushsingla commented 5 years ago

@Barbeau I think you are right. Do you have something in mind related to what new system can replace this?

barbeau commented 5 years ago

Not off the top of my head - I believe a database-based solution has been discussed in the past but I'd need to refresh my memory of all the details before recommending anything.

jaydeetay commented 5 years ago

I would quite like a database-based solution I think. Ultimately I'd like a base set of data, but have ability to download more as needed according to interest. I'd also like a much richer data model so that we can show more metadata about objects. So that's where I see this going. We're going to have to deal with localization somehow (which is the reason that the current build process is so awful).

On Wed, Apr 10, 2019 at 7:50 AM Sean Barbeau notifications@github.com wrote:

Not off the top of my head - I believe a database-based solution has been discussed in the past but I'd need to refresh my memory of all the details before recommending anything.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sky-map-team/stardroid/issues/296#issuecomment-481658062, or mute the thread https://github.com/notifications/unsubscribe-auth/APq7C267EwRHGz7KK0AvL5N1c3pADqYnks5vfdAYgaJpZM4cmEQw .

--

Google Pittsburgh is hiring again!

barbeau commented 5 years ago

@jaydeetay Regarding localization, this platform recently came on my radar and I plan on trying it for GPSTest: https://www.transifex.com/

It's free for OSS projects. I believe the catch is that the files to be localized need to be in plain text, but I'll report back more once I get to setting it up.