search

sky-map-team / stardroid

Sky Map (formerly Google Sky Map, open sourced in 2012)
https://play.google.com/store/apps/details?id=com.google.android.stardroid&hl=en
Apache License 2.0
926 stars 232 forks source link

Night Mode leaves navigation bar bright white. And other things too. #349

Open dobriai opened 4 years ago

dobriai commented 4 years ago

Summary:

When I switch to Night Mode the sky charts turn red, but some other things remain bright white, which almost defeats the purpose of the mode.

Steps to reproduce:

Switch to Night Mode.

Expected behavior:

All bright white stuff should be banished and all should be redish.

Observed behavior:

In Night Mode the following remain bright white or at least OS-default themed:

  1. The navigation bar (navbar) at the bottom
  2. The toast message "Switching to Manual Mode" is also left on white background
  3. The keyboard - if I want to use the search
  4. Smaller fry: The tab on the right to switch Manual/Auto
  5. Even smaller: The tabs on the left are either yellow or white. I suppose yellow if fine.

I might be missing some things, but the first three seem to be the brightest offender.

Device and Android version:

Android Oxygen 9.0.11 on OnePlus 5T phone

Screenshots:

I think these are unnecessary here, but let know if you need them.

Can be created by pressing the Volume Down and Power Button at the same time on Android 4.0 and higher.

dobriai commented 4 years ago

Great app, of course - thanks so much!

It is just unfortunate to "come so close" and not finish it off :-) If I can be of any help, let know! I am not a seasoned app developer, but if all else fails I can give it a try.

jaydeetay commented 4 years ago

Thanks for the detailed bug report Ivan. I also notice that on my phone at least, although the screen does go red it actually goes brighter than the 'default' setting in the dark. I seem to remember that 12 years ago when we implemented this we struggled a bit because of variation across phones - if you set the value too low it was invisible on some. Anyway - I'll look into it and see if there's an easy fix. The whole UI needs a refresh really.

On Fri, Aug 21, 2020 at 10:40 PM Ivan Dobrianov notifications@github.com wrote:

Great app, of course - thanks so much!

It is just unfortunate to "come so close" and not finish it off :-) If I can be of any help, let know! I am not a seasoned app developer, but if all else fails I can give it a try.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sky-map-team/stardroid/issues/349#issuecomment-678582809, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5LWC5TZMSXN6O6EDEOC5TSB4V2XANCNFSM4QH24XSA .

tzugen commented 2 years ago

Hey, actually the bug seems to be that in night mode the OS brightness setting seems to be overridden. On a Pixel 3 that Night mode is actually brighter than the lowest brightness I can set in the Android OS.

I am an Android developer and have capacities to work on this. See my profile for other OSS that I co-maintain. But I don't want to waste time on a PR that won't be accepted, so maybe you could write a bit what your focus regarding the UI would be?

hackerb9 commented 2 weeks ago

I am still experiencing this issue. The screen brightness gets cranked up which is perhaps reasonable for the red objects, but it is unusable because the user interface is glaringly bright as are notifications, such as the green GPS icon that appears when an app gets your location.

I notice that when I pull down from the top of the screen to adjust the system brightness, it has no effect, so sky map is definitely overriding the system setting.

I presume the hack for the screen being too dim on old phones was useful at the time, but perhaps now we can revert it or at least make it optional.

(Using Pixel 6 Pro with GrapheneOS, Android 15)