search

sky-map-team / stardroid

Sky Map (formerly Google Sky Map, open sourced in 2012)
https://play.google.com/store/apps/details?id=com.google.android.stardroid&hl=en
Apache License 2.0
939 stars 233 forks source link

Red (night) mode turns up screen brightness #515

Open zekooooo opened 1 week ago

zekooooo commented 1 week ago

Sony Xperia 1V, Android 14, Sky Map 1.10.4 - RC1 (F-Droid version)

When I click the eye icon to enter the red sky charts mode (or when I start the app, doesn't matter), the screen becomes significantly brighter instead of minimum brightness. This always happens in red charts mode, I can't have the sky charts red without the brightness going up.

Not a biggie since my screen is OLED and this is red light, but still, it would be nice to have screen dimming as usual.

jaydeetay commented 2 days ago

This is an oldie from back in the day when phones didn't really handle screen dimming properly. I don't see much need for the app to do it now....the phone's own screen brightness management is probably just fine (and as if you've noted...the 'dim' value used is actually pretty bright on most phones these days).

zekooooo commented 1 day ago

Could you add a compatibility setting to turn it off then? I mean in red night mode, backlight lights up probably ~100% like I'm in the photo app (on my old phone backlight would get turned down to minimum instead). The reason it isn't annoying is just that all color on the screen is red, so it's kind of on par with the ordinary blue background w/ no backlight

jaydeetay commented 1 day ago

I'm going to try something. Since we first implemented this (from looking at the Android source code!) it looks like they might have added a constant that means "really really dim". I'm going to add some options to use a) that b) the phone's automatic setting or c) the original value. If you're interested I can add you to the 'alpha testers' group and you can see how it works for you. Just send your google account name to @.*** and I'll add you. Another option is just to join our beta testers for the Google Play link. I see you're using the fdroid version though so these options might not appeal to you.

On Wed, Dec 4, 2024 at 6:08 PM zekooooo @.***> wrote:

Could you add a compatibility setting to turn it off then? I mean in red night mode, backlight lights up probably ~100% like I'm in the photo app (on my old phone backlight would get turned down to minimum instead). The reason it isn't annoying is just that all color on the screen is red, so it's kind of on par with the ordinary blue background w/ no backlight

— Reply to this email directly, view it on GitHub https://github.com/sky-map-team/stardroid/issues/515#issuecomment-2518741288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5LWC4XNVC34LXEH57T3AT2D6DO3AVCNFSM6AAAAABSUAXKR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJYG42DCMRYHA . You are receiving this because you commented.Message ID: @.***>

jaydeetay commented 1 day ago

Why thank you github for obfuscating our email address. Well....if you head on over to the Play Store you can contact us from there (if you want).

zekooooo commented 22 hours ago

Sorry, I nuked Google Services on my phone. If you can / want to push an alpha version to F-Droid I'll let you know how each option worked, I just checked that beta updates for Sky Map are enabled in my F-Droid.

Thanks for giving this thought. I have no idea if there are many F-Droid users on your app and I don't think Sonys are selling well so I'm really thankful you're hearing me out at all.