search

sky-music / sky-python-music-sheet-maker

Make visual music sheets for thatskygame (graphical representations of the Sky keyboard)
MIT License
29 stars 10 forks source link

Octave shift is confusing #198

Closed jmmelko closed 4 years ago

jmmelko commented 4 years ago

It seems that octave shift is broken. Shifting results in Xs, mostly. I have to check whether it is a parsing error or a range error.

This is important because the program starts from octave 1 while SkyStudio starts from octave 4.

jmmelko commented 4 years ago

Actually it’s not broken. It’s just that the starting octave when parsing and when rendering is 1, so the full octave range of the piano is 1-3

The problem is that SkyStudio starts at 4. So either we start at 4, OR I just change the English output to start at 4. Then if someone wants to feed the program again with English notes, they will have to shift by -3 octaves.

In the meantime I have changed the documentation to explain this.

jmmelko commented 4 years ago

Fixed in latest release. We can now choose the starting octave when instantiating a NoteParser