tracey-le
commented
5 years ago Ok I had a think about this over the past few days-
- so currently the Western notation only accepts notation in the key of C, the plan is to allow typing in other keys
I needed time to weigh between:
- only allowing two octaves in each major scale, which means ignoring all accidentals and ignoring all notes higher or lower than those two octaves e.g.
E major selected.
The following notes are allowed:
(E4, F#4, G#4, A4, B4, C#5, D#5, E5, F#5, G#5, A5, B5, C#6, D#6, E6)
Other notes will be ignored/produce an error icon.
Type line:(octave shift would be allowed)
- OR, provide some automation for the user, in translating from a music language with 88 chromatic notes (not all 88, but a portion of) to a selection of 12 possible major scales each with two octaves (15 notes)
For the second option:
- I think I would like to extend find_keys to prioritise the list of keys presented, based on how much each of the keys best match the frequency of notes the user typed. (E.g. say a user's song – such as Minecraft - Sweden – has the notes D, E, F#, G, G#, A, B, C#, with G occurring more often than G#. The user's song shares more notes with D major than A major. D major would be given a higher preference than A major) The user then chooses a key.
List of possible keys:
D major (Matches: 45)
A major (Matches: 30)
G major (Matches: 23)
# maybe only top 3 matches
C major (Matches: 20)
...- we parse each line. My piano teacher told me that the human ear often picks out higher notes more when listening to chords. We give preference to the higher notes and try to place each line within the 2 octaves.
maybe notes lower than the lowest allowed note can be shifted up an octave until it is in range (provided it doesn’t pass the highest note). and we can decide a bit later if this behaviour can be opted out (I think yes), and how to handle accidentals (print icon error, or automatically shift them one note up or down – based on if the phrase is going up or down at that point, or if shifting would make a repeated note next to it). [<- really not sure about these ideas in this paragraph yet, basically on handling cases that usually are handled by human judgment]
This is sort of based on how I transcribe other songs into Sky
I guess I just wanted to think a bit more about the behaviour/design, and draft some algorithms for these, before going into implementation (which jmmelko shared ideas with me in the other issue!)
jmmelko
The musical key changes in some places of Sky’s world. That would be cool to render visual sheets in other keys than the standard one (C).
As agreed with Tracey she will do it, in her own time (that’s a feature request not a real issue).