sky-uk / cqlmigrate

Cassandra schema migration library
BSD 3-Clause "New" or "Revised" License
47 stars 29 forks source link

Use different consistency levels for read and write operations #24

Closed kevinpotgieter closed 8 years ago

kevinpotgieter commented 8 years ago

…tency levels when applying schema updates.

Changes address issue: #23

jsravn commented 8 years ago

Adding lombok is quite a big change and probably deserves its own PR and discussion. We were trying to stick with core java w/ minimal dependencies.

edit: After talking with the guys, there is agreement we probably don't want lombok in cqlmigrate. It will bleed into all projects that depend on cqlmigrate - which may be okay for sky internal, but not as an open source public project. We spent a lot of time removing dependencies before open sourcing previously.

jsravn commented 8 years ago

Does it really need to be flexible? Can we instead just make schema updates WRITE=ALL and READ=ONE for everyone as a default?

We could keep it flexible, but it means that users can break it if they don't know what they're doing, and our tests are invalid for custom use cases. If we keep it flexible, I think we should:

kevinpotgieter commented 8 years ago

Thats a fair point RE introducing lombok. We'll remove the library dependency, and provide the boiler plate code back again.

kevinpotgieter commented 8 years ago

We'll also remove the ability for the used to provide the consistency levels, and introduce the defaults of write=ALL and read=LOCAL_ONE i.s.o ONE?

oliverlockwood commented 8 years ago

@jsravn anything further from your side?

jsravn commented 8 years ago

I'll have a look with @chbatey.

On Thu, 18 Feb 2016 8:31 am Oliver Lockwood notifications@github.com wrote:

@jsravn https://github.com/jsravn anything further from your side?

— Reply to this email directly or view it on GitHub https://github.com/sky-uk/cqlmigrate/pull/24#issuecomment-185596801.

oliverlockwood commented 8 years ago

@jsravn @chbatey ping?

jsravn commented 8 years ago

We'll take a look today.

jsravn commented 8 years ago

@oliverlockwood Any idea why the build failed?