Correct read/write consistency levels which were the wrong way round

sky-uk / cqlmigrate

Cassandra schema migration library

BSD 3-Clause "New" or "Revised" License

47 stars 29 forks source link

Closed oliverlockwood closed 8 years ago

oliverlockwood commented 8 years ago

In #24 we discussed at length setting:

Unfortunately, in the actual implementation we got this the wrong way round, and our tests tested themselves rather than the production code.

This PR aims to fix that. I changed the tests so they started failing, and then changed the prod code so the tests went green again.

After this goes in we will need to issue another release.

oliverlockwood commented 8 years ago

@kevinpotgieter FYI - we failed here :jack_o_lantern:

@balooo @jsravn please review ASAP

balooo commented 8 years ago

We try to review everything ASAP :smile:

oliverlockwood commented 8 years ago

@balooo well yes :stuck_out_tongue:

chbatey commented 8 years ago

Ok merge it ASAP

chbatey commented 8 years ago

I merged it ASAP

oliverlockwood commented 8 years ago

You guys :guitar:

jsravn commented 8 years ago

Review fail by me in #24 :(