Jose Taboada: Cassandra 3 added

[joseblas]

I've added Cassandra 3 compatibility. All the tests are passing. But would be nice to test that it works with Cassandra 2 also.

[joseblas]

The error is a bit rare of me, it works perfectly fine when passing -DstorageDir.

test {
    jvmArgs '-Dcassandra.storagedir=/tmp/cassandra'
}

and in travis.yml

script:
  - ./gradlew clean check -Dcassandra.storagedir=/tmp/cassandra

How can I fix this error in travis ?

[oliverlockwood]

Hi @joseblas - thanks for raising this PR. It'd obviously be great to verify that cqlmigrate can natively support Cassandra 3.x as well as 2.1.x.

I've spoken to @adamdougal and he's agreed to work with you to move this forward.

For what it's worth, my high-level thoughts are:

• We should change the compile scope of the Cassandra driver to compileOnly - similar to Maven's provided scope, as described in the Gradle blog. This forces users of cqlmigrate to choose their own driver version, which seems to me like a Good Thing.
• We could have multiple Gradle test modules, with varying testCompile dependency sets, one for each driver version that's supported (e.g. 2.1.x, 3.x, whatever else). Each of these could run the same suite of tests.

[joseblas]

Hi @oliverlockwood, thanks for your response. I was thinking in something different like having different versions. For instance 2.x.x for Cassandra 2 and so on.

[joseblas]

Hi @adamdougal, I've just pushed the changes.

[adamdougal]

@joseblas Think you just need to remove this line from the build.gradle:

//    testCompileAndFunctional 'org.cassandraunit:cassandra-unit-shaded:2.1.9.2'

And resolve the conflicts. Then this is good to go.

[joseblas]

@adamdougal, done.

[adamdougal]

Sorry, still got conflicts!

[joseblas]

@adamdougal, now done.

[adamdougal]

Sorry @joseblas, I should have mentioned this before. Can you squash your commits down to 1 commit please?

[joseblas]

Hi Adam, I am guessing if it's possible with the merge from upstream?

On 11 Nov 2016, at 09:21, Adam Dougal notifications@github.com wrote:

Sorry @joseblas, I should have mentioned this before. Can you squash your commits down to 1 commit please?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[adamdougal]

I think it should be ok yea.

[oliverlockwood]

@joseblas @adamdougal don't worry about squashing the commits, that can be done from the github GUI these days.