CassandraLockConfig.withClientId() method is prone to accidental misuse

sky-uk / cqlmigrate

Cassandra schema migration library

BSD 3-Clause "New" or "Revised" License

47 stars 29 forks source link

CassandraLockConfig.withClientId() method is prone to accidental misuse #43

Closed oliverlockwood closed 7 years ago

oliverlockwood commented 7 years ago

In order for the locking mechanism to work, each application instance has to use a unique client ID.

The CassandraLockConfig.withClientId() method is potentially misleading - if a client application uses a static value for this, instead of a UUID, then multiple instances can share the same lock and schema chaos may result.

@adamdougal and I believe this method should be either:

removed entirely, or
at least renamed to make it clear that the value provided should be a unique ID.

oliverlockwood commented 7 years ago

No objections have been received to the removal, so this method's on borrowed time.