search

sky-uk / cqlmigrate

Cassandra schema migration library
BSD 3-Clause "New" or "Revised" License
47 stars 29 forks source link

Add regression tests for Cassandra 2.x and 3.x #45

Open joseblas opened 7 years ago

joseblas commented 7 years ago

CqlMigrate should work in both versions, and should be able to be tested within both versions. Could be done by creating three modules: one for CqlMigrate and two other for tests. The latter should share the tests meanwhile is possible (no break changes)

joseblas commented 7 years ago

Something like this: https://github.com/joseblas/cqlmigrate/commits/SNS-with-regressiontests

oliverlockwood commented 7 years ago

@adamdougal can you take a look at this one please?

adamdougal commented 7 years ago

Kinda... Though I think it might be overkill to have a copy of all of the unit tests for each version. The change I'd make, is to move most of the unit tests to the cql module. Then just have a copy of the CqlMigratorImplTest in each of the testX modules so that it's tested end to end for each version.

As a minor thing, I'd probably rename the cql module to something different as it doesn't contain any cql, possible even just calling it cqlmigrate?

Good start though :)

joseblas commented 7 years ago

Hi Adam,

This is only an example how can be done.

I agree on the change of cql module to cqlmigrate, and the root one to cqlmigrate-parent (or similar).

And the tests are only in test2x, because are cassandra2 tests. In test3x there is only a ref to test2x.

To apply this a new fork should be done (or can I create a branch on the main project)

Regards, Jose.

On 29 Nov 2016, at 08:25, Adam Dougal notifications@github.com wrote:

Kinda... Though I think it might be overkill to have a copy of all of the unit tests for each version. The change I'd make, is to move most of the unit tests to the cql module. Then just have a copy of the CqlMigratorImplTest in each of the testX modules so that it's tested end to end for each version.

As a minor thing, I'd probably rename the cql module to something different as it doesn't contain any cql, possible even just calling it cqlmigrate?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.