sky-uk / cqlmigrate

Cassandra schema migration library
BSD 3-Clause "New" or "Revised" License
47 stars 29 forks source link

Trailing empty lines in cql files no longer allowed #83

Closed janssk1 closed 4 years ago

janssk1 commented 4 years ago

After upgrade from 0.9.6 to 0.9.8, previously working cql files no longer parse.

If a CQL files as more than one 'empty' line at the end, parsing fails with:

File had a non-terminated cql line java.lang.IllegalStateException: File had a non-terminated cql line at uk.sky.cqlmigrate.CqlFileParser$LineProcessor.check(CqlFileParser.java:179) at uk.sky.cqlmigrate.CqlFileParser$LineProcessor.access$100(CqlFileParser.java:39) at uk.sky.cqlmigrate.CqlFileParser.getCqlStatementsFrom(CqlFileParser.java:34) at uk.sky.cqlmigrate.CqlFileParserTest.trailingEmptyLinesAreAllowed(CqlFileParserTest.java:102)

This breaks backward compatibility. Changing old changelogs to remove the 'redundant' trailing empty lines is not an option, since that breaks SHA1's.