search

sky-uk / feed

Nginx based Kubernetes ingress controller for AWS
BSD 3-Clause "New" or "Revised" License
58 stars 10 forks source link

Expose status updater errors #180

Closed peterbale closed 6 years ago

peterbale commented 6 years ago

This is to return back any errors recieved when trying to set an ingress status rather than printing the names of the failed ingresses.

Closes #179

peterbale commented 6 years ago

I can see what you're saying around the use of multierror. Initially I was trying to find some way of deduping the errors, but it's not really possible. The error includes the full path it was trying to hit, so it will include the namespace and ingress etc, hence why it's so hard to dedupe. I'll update it to use a slice of errors instead as I do agree, it's pretty much the same without using the lib.