sky-uk / feed

Nginx based Kubernetes ingress controller for AWS
BSD 3-Clause "New" or "Revised" License
58 stars 10 forks source link

Replace fake_graceful_nginx.py #224

Closed alangibson01 closed 4 years ago

alangibson01 commented 4 years ago

I haven't done a full root-cause analysis, but it appears that the nginx tests which were flaky on Travis were due to the use of a Python based nginx fake implementation. I've replaced it with an equivalent Go implementation which doesn't cause the same flaky behaviour.

alangibson01 commented 4 years ago

Good suggestions. Implemented as requested.