Closed pyoio closed 2 years ago
Meant to ping @sky-uk/core-networking en masse to discuss, didn't realise it would randomly select @aecay 😬
The use case for us is to enable WebSocket connections in our mgmt cluster for mgmt tools (e.g., grafana, tekton ui) -- no plans to enable it in other clusters
Short term we're going to flip our mgmt tools w/ websockets over to using cloud native LBs which support WS, the support + HAProxy aspects make this something that's more appropriately considered in next-gen ingress work when that comes IMO, cheers @aecay!
Allows feed to support proxying WebSocket requests if explicitly enabled.
If enabled via the
--nginx-allow-websocket-upgrade
flag, the nginx configuration will be generated with the following block:Which will set the
Connection
header toupgrade
IF theUpgrade
header is present, otherwise theproxy_set_header Connection
will be""
which does not forward, the same as existing feed behaviour.If the flag is omitted, the nginx config will generate with:
as it previously did.