search

sky-uk / kafka-configurator

Kafka Topic Configurator
BSD 3-Clause "New" or "Revised" License
31 stars 9 forks source link

kafka-configurator doesn't attempt to configure all topics described #19

Closed oliverlockwood closed 7 years ago

oliverlockwood commented 7 years ago

Two issues here:

  1. [MINOR] The order of topic configuration that kafka-configurator performs does not match the order in the YML file. This makes it hard to check that we've done everything successfully.
  2. [BLOCKER] Some topics are completely ignored, with no logs at all, and it's unclear why; though the topics that are ignored are the same each time. Did YML parsing of them fail? Do comments in YML files cause problems for us?
oliverlockwood commented 7 years ago

Regarding item 1, this might help: https://github.com/circe/circe-yaml/issues/24

oliverlockwood commented 7 years ago

Item (1) fixed by https://github.com/sky-uk/kafka-configurator/pull/20.

oliverlockwood commented 7 years ago

Since the changes in #20, item (2) is no longer reproducible. Closing this issue now.