search

sky-uk / kfp-operator

https://sky-uk.github.io/kfp-operator
BSD 3-Clause "New" or "Revised" License
15 stars 2 forks source link

Make pipeline compile create json rather than yaml #383

Closed grahamia closed 3 weeks ago

grahamia commented 3 weeks ago

Closes #382 .

To test I changed the workflow and ran a pipeline workflow with 1.14 tfx and that worked fine. Then I upgraded quickstart to 1.15.1 and ran that through and again that worked fine so think this fixes the issue. Pipeline stored in json format and runs against it all worked successfully.

grahamia commented 3 weeks ago

We may need to support both JSON and YAML, ie. <TFX 1.15 and <=TFX 1.15. This PR proves we can support YAML. What proves we can support both? The fact you did manual tests may be acceptable?

This change forces the output of the compile to be json always, correcting the name of the file, the reference.yaml was json