sky-uk / kfp-operator

https://sky-uk.github.io/kfp-operator
BSD 3-Clause "New" or "Revised" License
15 stars 2 forks source link

Replace Argo Events stack with Provider Service component #391

Open alexgeorgousis opened 1 week ago

alexgeorgousis commented 1 week ago

Closes #359

Tasks

alexgeorgousis commented 6 days ago

I have a question about the way we've implemented the event processing for providers.

Up until this point, the steps to introduce a new provider (I think) were:

  1. Build a publish a docker image that handles CRUD for resources in the new provider and handles events coming out of the new provider
  2. Deploy a new Provider resource with that provider image specified

What we've basically done in this PR is move the event processing logic for the existing providers to a separate service.

So as far as I can tell, the steps are now:

  1. Build a publish a docker image that handles CRUD for resources in the new provider
  2. Deploy a new Provider resource with that provider image specified
  3. Raise a PR in the KFP Operator repo to extend the provider-service module with eventing logic for the new provider

Questions:

  1. Am I missing something?
  2. If not, do we think this is a problem?